xBis7 commented on code in PR #64902:
URL: https://github.com/apache/airflow/pull/64902#discussion_r3095940398
##########
dev/breeze/src/airflow_breeze/commands/kubernetes_commands.py:
##########
@@ -1349,6 +1368,23 @@ def _deploy_airflow(
check=False,
)
if result.returncode == 0:
+ otel_flags = _otel_flags_from_options(extra_options)
+ observability_files: list[str] = []
+ if "tracesEnabled" in otel_flags:
+ observability_files.append(str(SCRIPTS_CI_KUBERNETES_PATH /
"observability" / "jaeger.yaml"))
+ if "metricsEnabled" in otel_flags:
+ observability_files.append(str(SCRIPTS_CI_KUBERNETES_PATH /
"observability" / "prometheus.yaml"))
+ observability_files.append(str(SCRIPTS_CI_KUBERNETES_PATH /
"observability" / "grafana.yaml"))
+ if observability_files:
+ get_console(output=output).print("[info]Deploying observability
backends for enabled OTel flags.")
+ run_command_with_k8s_env(
+ ["kubectl", "apply", "--namespace", HELM_AIRFLOW_NAMESPACE]
+ + [arg for f in observability_files for arg in ("-f", f)],
+ python=python,
+ kubernetes_version=kubernetes_version,
+ output=output,
+ check=False,
+ )
Review Comment:
This part has been removed.
##########
scripts/ci/prek/lint_json_schema.py:
##########
@@ -111,7 +111,7 @@ def load_file(file_path: str):
return json.load(input_file)
elif file_path.lower().endswith((".yaml", ".yml")):
with open(file_path) as input_file:
- return yaml.safe_load(input_file)
+ return list(yaml.safe_load_all(input_file))
Review Comment:
This part has been removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
