potiuk commented on issue #65391: URL: https://github.com/apache/airflow/issues/65391#issuecomment-4264371680
To be honest, it's not really wrong. 500 means that there is an internal errors and you can **always** receive it - you should never declare something that is - by definition - an unexpected error. If it is "unexpected" error, by definition you do not expect it to be returned. So no violation of Open API spec happens here. Changing fernet key without rotating it properly is quite, well, unexpected. And it leaves the system in generally unusable state that should not happen at all if you have your deployment processes in order. And especially if the log is written on the server side explaining what happens. There are certain errors that you do not even want to expose because of security - for example if we provide a meaningul message as response in this case, potential attacker could find out you have misconfiured database with probably old data still encrypted with old fernet key, possibly because it's been leaked, which might give attacker a clue that grabbing your database dump now is a good idea, because someone has a stolen key. Hypothetical, but possible scenario. S o I am not sure what other HTTP error you would like to propose @shan-zeeshan786 ? Which of the "expected" HTTP errors you would like to see without leaking that you made mistake (re)configuring your installation ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
