Lee-W commented on code in PR #65197:
URL: https://github.com/apache/airflow/pull/65197#discussion_r3099633380
##########
providers/google/tests/system/google/cloud/dataflow/example_dataflow_native_python_async.py:
##########
@@ -100,7 +100,8 @@
# [START howto_sensor_wait_for_job_status]
wait_for_python_job_async_done = DataflowJobStatusSensor(
task_id="wait_for_python_job_async_done",
-
job_id="{{task_instance.xcom_pull('start_python_job_async')['dataflow_job_id']}}",
+ # verbose form: "{{
task_instance.xcom_pull('start_python_job_async')['dataflow_job_id'] }}"
+ job_id="{{start_python_job_async.output['dataflow_job_id']}}",
Review Comment:
```suggestion
job_id="{{ start_python_job_async.output['dataflow_job_id'] }}",
```
##########
providers/google/tests/system/google/cloud/dataflow/example_dataflow_go.py:
##########
@@ -113,7 +114,7 @@ def check_message(messages: list[dict]) -> bool:
wait_for_go_job_async_message = DataflowJobMessagesSensor(
task_id="wait_for_go_job_async_message",
-
job_id="{{task_instance.xcom_pull('start_go_pipeline_dataflow_runner')['dataflow_job_id']}}",
+
job_id="{{start_go_pipeline_dataflow_runner.output['dataflow_job_id']}}",
Review Comment:
```suggestion
job_id="{{
start_go_pipeline_dataflow_runner.output['dataflow_job_id'] }}",
```
##########
providers/google/tests/system/google/cloud/dataflow/example_dataflow_sensors_deferrable.py:
##########
@@ -138,7 +139,7 @@ def check_job_message(messages: list[dict]) -> bool:
wait_for_beam_python_pipeline_job_message_def = DataflowJobMessagesSensor(
task_id="wait_for_beam_python_pipeline_job_message_def",
-
job_id="{{task_instance.xcom_pull('start_beam_python_pipeline')['dataflow_job_id']}}",
+ job_id="{{start_beam_python_pipeline.output['dataflow_job_id']}}",
Review Comment:
```suggestion
job_id="{{ start_beam_python_pipeline.output['dataflow_job_id'] }}",
```
##########
providers/google/tests/system/google/cloud/storage_transfer/example_cloud_storage_transfer_service_aws.py:
##########
@@ -219,7 +220,7 @@
wait_for_operation_to_start_2 = CloudDataTransferServiceJobStatusSensor(
task_id="wait_for_operation_to_start_2",
-
job_name="{{task_instance.xcom_pull('create_transfer_job_s3_to_gcs_2')['name']}}",
+ job_name="{{create_transfer_job_s3_to_gcs_2.output['name']}}",
Review Comment:
```suggestion
job_name="{{ create_transfer_job_s3_to_gcs_2.output['name'] }}",
```
##########
providers/google/tests/system/google/cloud/dataflow/example_dataflow_sensors_deferrable.py:
##########
@@ -156,7 +157,7 @@ def check_autoscaling_event(autoscaling_events: list[dict])
-> bool:
wait_for_beam_python_pipeline_job_autoscaling_event_def =
DataflowJobAutoScalingEventsSensor(
task_id="wait_for_beam_python_pipeline_job_autoscaling_event_def",
-
job_id="{{task_instance.xcom_pull('start_beam_python_pipeline')['dataflow_job_id']}}",
+ job_id="{{start_beam_python_pipeline.output['dataflow_job_id']}}",
Review Comment:
```suggestion
job_id="{{ start_beam_python_pipeline.output['dataflow_job_id'] }}",
```
##########
providers/google/tests/system/google/cloud/storage_transfer/example_cloud_storage_transfer_service_gcp.py:
##########
@@ -141,21 +141,22 @@
# [START howto_operator_gcp_transfer_update_job]
update_transfer = CloudDataTransferServiceUpdateJobOperator(
task_id="update_transfer",
- job_name="{{task_instance.xcom_pull('create_transfer')['name']}}",
+ # verbose form: "{{ task_instance.xcom_pull('create_transfer')['name']
}}"
+ job_name="{{create_transfer.output['name']}}",
body=update_body,
)
# [END howto_operator_gcp_transfer_update_job]
wait_for_transfer = CloudDataTransferServiceJobStatusSensor(
task_id="wait_for_transfer",
- job_name="{{task_instance.xcom_pull('create_transfer')['name']}}",
+ job_name="{{create_transfer.output['name']}}",
project_id=PROJECT_ID_TRANSFER,
expected_statuses={GcpTransferOperationStatus.SUCCESS},
)
wait_for_transfer_defered = CloudDataTransferServiceJobStatusSensor(
task_id="wait_for_transfer_defered",
- job_name="{{task_instance.xcom_pull('create_transfer')['name']}}",
+ job_name="{{create_transfer.output['name']}}",
Review Comment:
```suggestion
job_name="{{ create_transfer.output['name'] }}",
```
##########
providers/google/tests/system/google/cloud/storage_transfer/example_cloud_storage_transfer_service_aws.py:
##########
@@ -178,27 +179,27 @@
task_id="list_operations",
request_filter={
FILTER_PROJECT_ID: GCP_PROJECT_ID,
- FILTER_JOB_NAMES:
["{{task_instance.xcom_pull('create_transfer_job_s3_to_gcs')['name']}}"],
+ FILTER_JOB_NAMES:
["{{create_transfer_job_s3_to_gcs.output['name']}}"],
},
)
# [END howto_operator_gcp_transfer_list_operations]
# [START howto_operator_gcp_transfer_get_operation]
get_operation = CloudDataTransferServiceGetOperationOperator(
- task_id="get_operation",
operation_name="{{task_instance.xcom_pull('list_operations')[0]['name']}}"
+ task_id="get_operation",
operation_name="{{list_operations.output[0]['name']}}"
Review Comment:
```suggestion
task_id="get_operation", operation_name="{{
list_operations.output[0]['name'] }}"
```
##########
providers/google/tests/system/google/cloud/vertex_ai/example_vertex_ai_batch_prediction_job.py:
##########
@@ -161,7 +162,8 @@
create_batch_prediction_job_def = CreateBatchPredictionJobOperator(
task_id="create_batch_prediction_job_def",
job_display_name=JOB_DISPLAY_NAME,
- model_name="{{ti.xcom_pull('auto_ml_forecasting_task')['name']}}",
+ # verbose form: "{{ ti.xcom_pull('auto_ml_forecasting_task')['name']
}}"
+ model_name="{{auto_ml_forecasting_task.output['name']}}",
Review Comment:
```suggestion
model_name="{{ auto_ml_forecasting_task.output['name'] }}",
```
##########
providers/google/tests/system/google/cloud/dataflow/example_dataflow_sensors_deferrable.py:
##########
@@ -120,7 +121,7 @@ def callback(metrics: list[dict]) -> bool:
wait_for_beam_python_pipeline_job_metric_def = DataflowJobMetricsSensor(
task_id="wait_for_beam_python_pipeline_job_metric_def",
-
job_id="{{task_instance.xcom_pull('start_beam_python_pipeline')['dataflow_job_id']}}",
+ job_id="{{start_beam_python_pipeline.output['dataflow_job_id']}}",
Review Comment:
```suggestion
job_id="{{ start_beam_python_pipeline.output['dataflow_job_id'] }}",
```
##########
providers/google/tests/system/google/cloud/storage_transfer/example_cloud_storage_transfer_service_aws.py:
##########
@@ -208,7 +209,7 @@
# [START howto_operator_gcp_transfer_update_job]
update_transfer_job_s3_to_gcs = CloudDataTransferServiceUpdateJobOperator(
task_id="update_transfer_job_s3_to_gcs",
-
job_name="{{task_instance.xcom_pull('create_transfer_job_s3_to_gcs')['name']}}",
+ job_name="{{create_transfer_job_s3_to_gcs.output['name']}}",
Review Comment:
```suggestion
job_name="{{ create_transfer_job_s3_to_gcs.output['name'] }}",
```
##########
providers/google/tests/system/google/cloud/storage_transfer/example_cloud_storage_transfer_service_aws.py:
##########
@@ -178,27 +179,27 @@
task_id="list_operations",
request_filter={
FILTER_PROJECT_ID: GCP_PROJECT_ID,
- FILTER_JOB_NAMES:
["{{task_instance.xcom_pull('create_transfer_job_s3_to_gcs')['name']}}"],
+ FILTER_JOB_NAMES:
["{{create_transfer_job_s3_to_gcs.output['name']}}"],
},
)
# [END howto_operator_gcp_transfer_list_operations]
# [START howto_operator_gcp_transfer_get_operation]
get_operation = CloudDataTransferServiceGetOperationOperator(
- task_id="get_operation",
operation_name="{{task_instance.xcom_pull('list_operations')[0]['name']}}"
+ task_id="get_operation",
operation_name="{{list_operations.output[0]['name']}}"
)
# [END howto_operator_gcp_transfer_get_operation]
# [START howto_operator_gcp_transfer_resume_operation]
resume_operation = CloudDataTransferServiceResumeOperationOperator(
- task_id="resume_operation",
operation_name="{{task_instance.xcom_pull('get_operation')['name']}}"
+ task_id="resume_operation",
operation_name="{{get_operation.output['name']}}"
)
# [END howto_operator_gcp_transfer_resume_operation]
# [START howto_operator_gcp_transfer_wait_operation]
wait_for_operation_to_end = CloudDataTransferServiceJobStatusSensor(
task_id="wait_for_operation_to_end",
-
job_name="{{task_instance.xcom_pull('create_transfer_job_s3_to_gcs')['name']}}",
+ job_name="{{create_transfer_job_s3_to_gcs.output['name']}}",
Review Comment:
```suggestion
job_name="{{ create_transfer_job_s3_to_gcs.output['name'] }}",
```
##########
providers/google/tests/system/google/cloud/storage_transfer/example_cloud_storage_transfer_service_aws.py:
##########
@@ -178,27 +179,27 @@
task_id="list_operations",
request_filter={
FILTER_PROJECT_ID: GCP_PROJECT_ID,
- FILTER_JOB_NAMES:
["{{task_instance.xcom_pull('create_transfer_job_s3_to_gcs')['name']}}"],
+ FILTER_JOB_NAMES:
["{{create_transfer_job_s3_to_gcs.output['name']}}"],
},
)
# [END howto_operator_gcp_transfer_list_operations]
# [START howto_operator_gcp_transfer_get_operation]
get_operation = CloudDataTransferServiceGetOperationOperator(
- task_id="get_operation",
operation_name="{{task_instance.xcom_pull('list_operations')[0]['name']}}"
+ task_id="get_operation",
operation_name="{{list_operations.output[0]['name']}}"
)
# [END howto_operator_gcp_transfer_get_operation]
# [START howto_operator_gcp_transfer_resume_operation]
resume_operation = CloudDataTransferServiceResumeOperationOperator(
- task_id="resume_operation",
operation_name="{{task_instance.xcom_pull('get_operation')['name']}}"
+ task_id="resume_operation",
operation_name="{{get_operation.output['name']}}"
Review Comment:
```suggestion
task_id="resume_operation", operation_name="{{
get_operation.output['name'] }}"
```
##########
providers/google/tests/system/google/cloud/dataprep/example_dataprep.py:
##########
@@ -76,10 +76,13 @@
DATASET_URI =
"gs://airflow-system-tests-resources/dataprep/dataset-00000.parquet"
DATASET_NAME = f"dataset_{DAG_ID}_{ENV_ID}".replace("-", "_")
DATASET_WRANGLED_NAME = f"wrangled_{DATASET_NAME}"
-DATASET_WRANGLED_ID = "{{
task_instance.xcom_pull('create_wrangled_dataset')['id'] }}"
+DATASET_WRANGLED_ID = ("{{ create_wrangled_dataset.output['id'] }}",)
+# verbose form: "{{ task_instance.xcom_pull('create_wrangled_dataset')['id']
}}"
Review Comment:
```suggestion
# verbose form: "{{ task_instance.xcom_pull('create_wrangled_dataset')['id']
}}"
DATASET_WRANGLED_ID = ("{{ create_wrangled_dataset.output['id'] }}",
```
##########
providers/google/tests/system/google/cloud/dataflow/example_dataflow_native_python_async.py:
##########
@@ -141,7 +142,7 @@ def check_message(messages: list[dict]) -> bool:
wait_for_python_job_async_message = DataflowJobMessagesSensor(
task_id="wait_for_python_job_async_message",
-
job_id="{{task_instance.xcom_pull('start_python_job_async')['dataflow_job_id']}}",
+ job_id="{{start_python_job_async.output['dataflow_job_id']}}",
Review Comment:
```suggestion
job_id="{{ start_python_job_async.output['dataflow_job_id'] }}",
```
##########
providers/google/tests/system/google/cloud/storage_transfer/example_cloud_storage_transfer_service_aws.py:
##########
@@ -236,15 +237,15 @@
# [START howto_operator_gcp_transfer_delete_job]
delete_transfer_job_s3_to_gcs = CloudDataTransferServiceDeleteJobOperator(
task_id="delete_transfer_job_s3_to_gcs",
-
job_name="{{task_instance.xcom_pull('create_transfer_job_s3_to_gcs')['name']}}",
+ job_name="{{create_transfer_job_s3_to_gcs.output['name']}}",
project_id=GCP_PROJECT_ID,
trigger_rule=TriggerRule.ALL_DONE,
)
# [END howto_operator_gcp_transfer_delete_job]
delete_transfer_job_s3_to_gcs_2 =
CloudDataTransferServiceDeleteJobOperator(
task_id="delete_transfer_job_s3_to_gcs_2",
-
job_name="{{task_instance.xcom_pull('create_transfer_job_s3_to_gcs_2')['name']}}",
+ job_name="{{create_transfer_job_s3_to_gcs_2.output['name']}}",
Review Comment:
```suggestion
job_name="{{ create_transfer_job_s3_to_gcs_2.output['name'] }}",
```
##########
providers/google/tests/system/google/cloud/storage_transfer/example_cloud_storage_transfer_service_aws.py:
##########
@@ -178,27 +179,27 @@
task_id="list_operations",
request_filter={
FILTER_PROJECT_ID: GCP_PROJECT_ID,
- FILTER_JOB_NAMES:
["{{task_instance.xcom_pull('create_transfer_job_s3_to_gcs')['name']}}"],
+ FILTER_JOB_NAMES:
["{{create_transfer_job_s3_to_gcs.output['name']}}"],
Review Comment:
```suggestion
FILTER_JOB_NAMES: ["{{
create_transfer_job_s3_to_gcs.output['name'] }}"],
```
##########
providers/google/tests/system/google/cloud/dataflow/example_dataflow_native_python_async.py:
##########
@@ -158,7 +159,7 @@ def check_autoscaling_event(autoscaling_events: list[dict])
-> bool:
wait_for_python_job_async_autoscaling_event =
DataflowJobAutoScalingEventsSensor(
task_id="wait_for_python_job_async_autoscaling_event",
-
job_id="{{task_instance.xcom_pull('start_python_job_async')['dataflow_job_id']}}",
+ job_id="{{start_python_job_async.output['dataflow_job_id']}}",
Review Comment:
```suggestion
job_id="{{ start_python_job_async.output['dataflow_job_id'] }}",
```
##########
providers/google/tests/system/google/cloud/storage_transfer/example_cloud_storage_transfer_service_aws.py:
##########
@@ -236,15 +237,15 @@
# [START howto_operator_gcp_transfer_delete_job]
delete_transfer_job_s3_to_gcs = CloudDataTransferServiceDeleteJobOperator(
task_id="delete_transfer_job_s3_to_gcs",
-
job_name="{{task_instance.xcom_pull('create_transfer_job_s3_to_gcs')['name']}}",
+ job_name="{{create_transfer_job_s3_to_gcs.output['name']}}",
Review Comment:
```suggestion
job_name="{{ create_transfer_job_s3_to_gcs.output['name'] }}",
```
##########
providers/apache/beam/tests/system/apache/beam/example_python_dataflow.py:
##########
@@ -69,7 +69,8 @@
wait_for_python_job_dataflow_runner_async_done = DataflowJobStatusSensor(
task_id="wait-for-python-job-async-done",
-
job_id="{{task_instance.xcom_pull('start_python_job_dataflow_runner_async')['dataflow_job_id']}}",
+ # verbose form: "{{
task_instance.xcom_pull('start_python_job_dataflow_runner_async')['dataflow_job_id']
}}"
+
job_id="{{start_python_job_dataflow_runner_async.output['dataflow_job_id']}}",
Review Comment:
```suggestion
job_id="{{
start_python_job_dataflow_runner_async.output['dataflow_job_id'] }}",
```
##########
providers/google/tests/system/google/cloud/data_loss_prevention/example_dlp_deidentify_content.py:
##########
@@ -111,7 +111,8 @@
reidentify_content = CloudDLPReidentifyContentOperator(
task_id="reidentify_content",
project_id=PROJECT_ID,
- item=ContentItem(value="{{
task_instance.xcom_pull('deidentify_content')['item'] }}"),
+ item=ContentItem(value="{{ deidentify_content.output['item'] }}"),
+ # verbose form: "{{
task_instance.xcom_pull('deidentify_content')['item'] }}"
Review Comment:
```suggestion
# verbose form: "{{
task_instance.xcom_pull('deidentify_content')['item'] }}"
item=ContentItem(value="{{ deidentify_content.output['item'] }}"),
```
##########
providers/google/tests/system/google/cloud/dataflow/example_dataflow_sensors_deferrable.py:
##########
@@ -95,7 +95,8 @@
# [START howto_sensor_wait_for_job_status_deferrable]
wait_for_beam_python_pipeline_job_status_def = DataflowJobStatusSensor(
task_id="wait_for_beam_python_pipeline_job_status_def",
-
job_id="{{task_instance.xcom_pull('start_beam_python_pipeline')['dataflow_job_id']}}",
+ # verbose form: "{{
task_instance.xcom_pull('start_beam_python_pipeline')['dataflow_job_id'] }}"
+ job_id="{{start_beam_python_pipeline.output['dataflow_job_id']}}",
Review Comment:
```suggestion
job_id="{{ start_beam_python_pipeline.output['dataflow_job_id'] }}",
```
##########
providers/google/tests/system/google/cloud/storage_transfer/example_cloud_storage_transfer_service_gcp.py:
##########
@@ -173,18 +174,18 @@
task_id="list_operations",
request_filter={
FILTER_PROJECT_ID: PROJECT_ID_TRANSFER,
- FILTER_JOB_NAMES:
["{{task_instance.xcom_pull('create_transfer')['name']}}"],
+ FILTER_JOB_NAMES: ["{{create_transfer.output['name']}}"],
},
)
get_operation = CloudDataTransferServiceGetOperationOperator(
task_id="get_operation",
-
operation_name="{{task_instance.xcom_pull('list_operations')[0]['name']}}",
+ operation_name="{{list_operations.output[0]['name']}}",
Review Comment:
```suggestion
operation_name="{{ list_operations.output[0]['name'] }}",
```
##########
providers/google/tests/system/google/cloud/dataflow/example_dataflow_go.py:
##########
@@ -128,7 +129,7 @@ def check_autoscaling_event(autoscaling_events: list[dict])
-> bool:
wait_for_go_job_async_autoscaling_event =
DataflowJobAutoScalingEventsSensor(
task_id="wait_for_go_job_async_autoscaling_event",
-
job_id="{{task_instance.xcom_pull('start_go_pipeline_dataflow_runner')['dataflow_job_id']}}",
+
job_id="{{start_go_pipeline_dataflow_runner.output['dataflow_job_id']}}",
Review Comment:
```suggestion
job_id="{{
start_go_pipeline_dataflow_runner.output['dataflow_job_id'] }}",
```
##########
providers/google/tests/system/google/cloud/storage_transfer/example_cloud_storage_transfer_service_gcp.py:
##########
@@ -173,18 +174,18 @@
task_id="list_operations",
request_filter={
FILTER_PROJECT_ID: PROJECT_ID_TRANSFER,
- FILTER_JOB_NAMES:
["{{task_instance.xcom_pull('create_transfer')['name']}}"],
+ FILTER_JOB_NAMES: ["{{create_transfer.output['name']}}"],
},
)
get_operation = CloudDataTransferServiceGetOperationOperator(
task_id="get_operation",
-
operation_name="{{task_instance.xcom_pull('list_operations')[0]['name']}}",
+ operation_name="{{list_operations.output[0]['name']}}",
)
delete_transfer = CloudDataTransferServiceDeleteJobOperator(
task_id="delete_transfer_from_gcp_job",
- job_name="{{task_instance.xcom_pull('create_transfer')['name']}}",
+ job_name="{{create_transfer.output['name']}}",
Review Comment:
```suggestion
job_name="{{ create_transfer.output['name'] }}",
```
##########
providers/apache/beam/tests/system/apache/beam/example_go_dataflow.py:
##########
@@ -66,7 +66,8 @@
wait_for_go_job_dataflow_runner_async_done = DataflowJobStatusSensor(
task_id="wait-for-go-job-async-done",
-
job_id="{{task_instance.xcom_pull('start_go_job_dataflow_runner_async')['dataflow_job_id']}}",
+ # verbose form: "{{
task_instance.xcom_pull('start_go_job_dataflow_runner_async')['dataflow_job_id']
}}"
+
job_id="{{start_go_job_dataflow_runner_async.output['dataflow_job_id']}}",
Review Comment:
```suggestion
job_id="{{
start_go_job_dataflow_runner_async.output['dataflow_job_id'] }}",
```
##########
providers/google/tests/system/google/cloud/dataflow/example_dataflow_go.py:
##########
@@ -99,7 +99,8 @@
wait_for_go_job_async_done = DataflowJobStatusSensor(
task_id="wait_for_go_job_async_done",
-
job_id="{{task_instance.xcom_pull('start_go_pipeline_dataflow_runner')['dataflow_job_id']}}",
+ # verbose form: "{{
task_instance.xcom_pull('start_go_pipeline_dataflow_runner')['dataflow_job_id']
}}"
+
job_id="{{start_go_pipeline_dataflow_runner.output['dataflow_job_id']}}",
Review Comment:
```suggestion
job_id="{{
start_go_pipeline_dataflow_runner.output['dataflow_job_id'] }}",
```
##########
providers/google/tests/system/google/cloud/storage_transfer/example_cloud_storage_transfer_service_gcp.py:
##########
@@ -141,21 +141,22 @@
# [START howto_operator_gcp_transfer_update_job]
update_transfer = CloudDataTransferServiceUpdateJobOperator(
task_id="update_transfer",
- job_name="{{task_instance.xcom_pull('create_transfer')['name']}}",
+ # verbose form: "{{ task_instance.xcom_pull('create_transfer')['name']
}}"
+ job_name="{{create_transfer.output['name']}}",
Review Comment:
```suggestion
job_name="{{ create_transfer.output['name'] }}",
```
##########
providers/google/tests/system/google/cloud/vertex_ai/example_vertex_ai_model_service.py:
##########
@@ -111,7 +111,8 @@
MODEL_SERVING_CONTAINER_URI =
"us-docker.pkg.dev/vertex-ai/prediction/tf2-cpu.2-2:latest"
MODEL_OBJ = {
"display_name": f"model-{ENV_ID}",
- "artifact_uri": "{{ti.xcom_pull('custom_task')['artifactUri']}}",
+ # verbose form: "{{ ti.xcom_pull('custom_task')['artifactUri'] }}"
+ "artifact_uri": "{{custom_task.output['artifactUri']}}",
Review Comment:
```suggestion
"artifact_uri": "{{ custom_task.output['artifactUri'] }}",
```
##########
providers/google/tests/system/google/cloud/vertex_ai/example_vertex_ai_model_service.py:
##########
@@ -124,7 +125,8 @@
}
MODEL_OBJ_V2 = {
"display_name": f"model-{ENV_ID}-v2",
- "artifact_uri": "{{ti.xcom_pull('custom_task')['artifactUri']}}",
+ # verbose form: "{{ ti.xcom_pull('custom_task')['artifactUri'] }}"
+ "artifact_uri": "{{custom_task.output['artifactUri']}}",
Review Comment:
```suggestion
"artifact_uri": "{{ custom_task.output['artifactUri'] }}",
```
##########
providers/google/tests/system/google/cloud/storage_transfer/example_cloud_storage_transfer_service_gcp.py:
##########
@@ -141,21 +141,22 @@
# [START howto_operator_gcp_transfer_update_job]
update_transfer = CloudDataTransferServiceUpdateJobOperator(
task_id="update_transfer",
- job_name="{{task_instance.xcom_pull('create_transfer')['name']}}",
+ # verbose form: "{{ task_instance.xcom_pull('create_transfer')['name']
}}"
+ job_name="{{create_transfer.output['name']}}",
body=update_body,
)
# [END howto_operator_gcp_transfer_update_job]
wait_for_transfer = CloudDataTransferServiceJobStatusSensor(
task_id="wait_for_transfer",
- job_name="{{task_instance.xcom_pull('create_transfer')['name']}}",
+ job_name="{{create_transfer.output['name']}}",
Review Comment:
```suggestion
job_name="{{ create_transfer.output['name'] }}",
```
##########
providers/google/tests/system/google/cloud/vertex_ai/example_vertex_ai_endpoint.py:
##########
@@ -124,7 +124,8 @@
DEPLOYED_MODEL = {
# format: 'projects/{project}/locations/{location}/models/{model}'
- "model": "{{ti.xcom_pull('auto_ml_image_task')['name']}}",
+ # verbose form: "{{ ti.xcom_pull('auto_ml_image_task')['name'] }}"
+ "model": "{{auto_ml_image_task.output['name']}}",
Review Comment:
```suggestion
"model": "{{ auto_ml_image_task.output['name'] }}",
```
##########
providers/google/tests/system/google/cloud/storage_transfer/example_cloud_storage_transfer_service_gcp.py:
##########
@@ -173,18 +174,18 @@
task_id="list_operations",
request_filter={
FILTER_PROJECT_ID: PROJECT_ID_TRANSFER,
- FILTER_JOB_NAMES:
["{{task_instance.xcom_pull('create_transfer')['name']}}"],
+ FILTER_JOB_NAMES: ["{{create_transfer.output['name']}}"],
Review Comment:
```suggestion
FILTER_JOB_NAMES: ["{{ create_transfer.output['name'] }}"],
```
##########
providers/google/tests/system/google/cloud/vertex_ai/example_vertex_ai_batch_prediction_job.py:
##########
@@ -147,7 +147,8 @@
create_batch_prediction_job = CreateBatchPredictionJobOperator(
task_id="create_batch_prediction_job",
job_display_name=JOB_DISPLAY_NAME,
- model_name="{{ti.xcom_pull('auto_ml_forecasting_task')['name']}}",
+ # verbose form: "{{ ti.xcom_pull('auto_ml_forecasting_task')['name']
}}"
+ model_name="{{auto_ml_forecasting_task.output['name']}}",
Review Comment:
```suggestion
model_name="{{ auto_ml_forecasting_task.output['name'] }}",
```
##########
providers/google/tests/system/google/cloud/storage_transfer/example_cloud_storage_transfer_service_gcp.py:
##########
@@ -164,7 +165,7 @@
# [START howto_operator_gcp_transfer_run_job]
run_transfer = CloudDataTransferServiceRunJobOperator(
task_id="run_transfer",
- job_name="{{task_instance.xcom_pull('create_transfer')['name']}}",
+ job_name="{{create_transfer.output['name']}}",
Review Comment:
```suggestion
job_name="{{ create_transfer.output['name'] }}",
```
##########
providers/google/tests/system/google/cloud/dataflow/example_dataflow_native_python_async.py:
##########
@@ -124,7 +125,7 @@ def callback(metrics: list[dict]) -> bool:
wait_for_python_job_async_metric = DataflowJobMetricsSensor(
task_id="wait_for_python_job_async_metric",
-
job_id="{{task_instance.xcom_pull('start_python_job_async')['dataflow_job_id']}}",
+ job_id="{{start_python_job_async.output['dataflow_job_id']}}",
Review Comment:
```suggestion
job_id="{{ start_python_job_async.output['dataflow_job_id'] }}",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
