Copilot commented on code in PR #65412:
URL: https://github.com/apache/airflow/pull/65412#discussion_r3100270670
##########
airflow-core/src/airflow/config_templates/airflow_local_settings.py:
##########
@@ -370,4 +370,4 @@ def _default_conn_name_from(mod_path, hook_name):
"section 'elasticsearch' if you are using Elasticsearch. In the
other case, "
"'remote_base_log_folder' option in the 'logging' section."
)
-
DEFAULT_LOGGING_CONFIG["handlers"]["task"].update(remote_task_handler_kwargs)
+ DEFAULT_LOGGING_CONFIG["handlers"]["task"].update(_handler_kwargs)
Review Comment:
Consider adding a regression test that sets `logging.remote_logging=True`,
uses a WASB `remote_base_log_folder`, and sets
`logging.remote_task_handler_kwargs` containing keys like
`remote_base`/`wasb_container`, then asserts
`logging.config.dictConfig(DEFAULT_LOGGING_CONFIG)` (or `configure_logging()`)
succeeds and that the instantiated `task` handler does not receive those
RemoteLogIO-only kwargs. This would prevent reintroducing the startup
`TypeError` this change fixes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
