pierrejeambrun commented on code in PR #64939:
URL: https://github.com/apache/airflow/pull/64939#discussion_r3101276098
##########
airflow-core/src/airflow/models/backfill.py:
##########
Review Comment:
dag_run_conf=None default on `_handle_clear_run` (backfill.py:523)
Only `_create_backfill_dag_run_non_partitioned` passes dag_run_conf
through — the partitioned variant doesn't (line 477 passes it to create_dagrun
but no _handle_clear_run path exists in
`_create_backfill_dag_run_partitioned`). That's because partitioned backfills
don't currently reprocess existing runs, but it's worth a comment, otherwise a
future maintainer will think it was an oversight.
##########
airflow-core/src/airflow/models/backfill.py:
##########
@@ -264,6 +265,8 @@ def _validate_backfill_params(
current_time = timezone.utcnow()
if from_date >= current_time and to_date >= current_time:
raise InvalidBackfillDate("Backfill cannot be executed for future
dates.")
+ if dag_run_conf is not None:
+ dag.params.deep_merge(dag_run_conf).validate()
Review Comment:
This needs to be fixed in this PR. Getting 500 error for a bad user
configuration is not ideal. Also it's a really straight forward fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
