Nandann018-ux commented on code in PR #64133:
URL: https://github.com/apache/airflow/pull/64133#discussion_r3101723729
##########
airflow-core/docs/conf.py:
##########
@@ -244,13 +245,20 @@ def
add_airflow_core_exclude_patterns_to_sphinx(exclude_patterns: list[str]):
config_descriptions =
retrieve_configuration_description(include_providers=False)
configs, deprecated_options = get_configs_and_deprecations(airflow_version,
config_descriptions)
+# TODO: remove it when we start releasing task-sdk separately from airflow-core
+airflow_version_split = PACKAGE_VERSION.split(".")
+TASK_SDK_VERSION = f"1.{airflow_version_split[1]}.{airflow_version_split[2]}"
Review Comment:
This one came from the earlier bad rebase that briefly pulled unrelated docs
and CI files into the PR. I rebuilt the branch cleanly on top of `main`, and
those files are no longer part of this change, so this thread no longer applies.
##########
.github/actions/post_tests_failure/action.yml:
##########
@@ -22,21 +22,21 @@ runs:
using: "composite"
steps:
- name: "Upload airflow logs"
- uses: actions/upload-artifact@v4
+ uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02
# v4.6.2
with:
name: airflow-logs-${{env.JOB_ID}}
path: './files/airflow_logs*'
retention-days: 7
if-no-files-found: ignore
- name: "Upload container logs"
- uses: actions/upload-artifact@v4
+ uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02
# v4.6.2
with:
name: container-logs-${{env.JOB_ID}}
path: "./files/container_logs*"
retention-days: 7
if-no-files-found: ignore
- name: "Upload other logs"
- uses: actions/upload-artifact@v4
+ uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02
# v4.6.2
with:
name: container-logs-${{env.JOB_ID}}
Review Comment:
This one came from the earlier bad rebase that briefly pulled unrelated docs
and CI files into the PR. I rebuilt the branch cleanly on top of `main`, and
those files are no longer part of this change, so this thread no longer applies.
##########
INSTALL:
##########
@@ -231,15 +265,15 @@ that are used in main CI tests and by other contributors.
There are different constraint files for different Python versions. For
example, this command will install
all basic devel requirements and requirements of Google provider as last
successfully tested for Python 3.10:
- uv pip install -e ".[devel,google]"" \
+ pip install -e ".[devel,google]"" \
Review Comment:
This one came from the earlier bad rebase that briefly pulled unrelated docs
and CI files into the PR. I rebuilt the branch cleanly on top of `main`, and
those files are no longer part of this change, so this thread no longer applies.
##########
INSTALL:
##########
@@ -231,15 +265,15 @@ that are used in main CI tests and by other contributors.
There are different constraint files for different Python versions. For
example, this command will install
all basic devel requirements and requirements of Google provider as last
successfully tested for Python 3.10:
- uv pip install -e ".[devel,google]"" \
+ pip install -e ".[devel,google]"" \
--constraint
"https://raw.githubusercontent.com/apache/airflow/constraints-main/constraints-3.10.txt";
Using the 'constraints-no-providers' constraint files, you can upgrade Airflow
without paying attention to the provider's dependencies. This allows you to
keep installed provider dependencies and install the latest supported ones
using pure Airflow core.
- uv pip install -e ".[devel]" \
+ pip install -e ".[devel]" \
Review Comment:
This one came from the earlier bad rebase that briefly pulled unrelated docs
and CI files into the PR. I rebuilt the branch cleanly on top of `main`, and
those files are no longer part of this change, so this thread no longer applies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
