hkc-8010 commented on PR #65239:
URL: https://github.com/apache/airflow/pull/65239#issuecomment-4272878273
@jscheffl All your review comments have been addressed:
- **Newsfragment**: Removed.
- **Help text**: Simplified to a single concise sentence.
- **AirflowException**: Replaced with `RuntimeError`.
- **Duplicate output**: Restructured so the summary warning is only emitted
when the flag is *not* set — when `error_on_cleanup_failure=True`, the
`RuntimeError` message already lists the failed tables, avoiding duplicate
output.
- **caplog**: Replaced all `caplog` usage in the affected tests with
`patch('airflow.utils.db_cleanup.logger')` and `assert_any_call` assertions.
Would you mind taking another look when you get a chance? Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
