kaxil commented on code in PR #65458:
URL: https://github.com/apache/airflow/pull/65458#discussion_r3105835561
##########
airflow-core/src/airflow/jobs/scheduler_job_runner.py:
##########
@@ -964,14 +964,15 @@ def _get_sentry_integration(executor: BaseExecutor) ->
str:
continue
if not ti.dag_version_id:
self.log.warning(
- "TaskInstance %s does not have a dag_version_id set,
cannot be enqueued. "
+ "TaskInstance %s (ti_id=%s) does not have a dag_version_id
set, cannot be enqueued. "
Review Comment:
Good call -- done in 3b7468eda9. Moved `ti_id` into `TaskInstance.__repr__`
so every TI log line that uses `%s` now carries `ti_id` for free, and reverted
the per-log-line additions that are now redundant.
Kept explicit `ti_id=%s` in two spots where repr doesn't apply: the
"TaskInstance Finished" msg (formats individual dag_id/task_id/... fields, not
`%s` on the TI) and the DAG processor's structlog-kwargs calls.
Also updated one test in `test_scheduler_job.py` that hardcoded the exact
repr string. Net diff shrunk from +61/-16 to +51/-14.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
