jason810496 commented on code in PR #64823:
URL: https://github.com/apache/airflow/pull/64823#discussion_r3108596084
##########
airflow-core/tests/unit/serialization/test_encoders.py:
##########
@@ -25,8 +25,30 @@
from airflow.serialization.enums import DagAttributeTypes as DAT, Encoding
from airflow.triggers.base import BaseEventTrigger
-pytest.importorskip("airflow.providers.apache.kafka")
-from airflow.providers.apache.kafka.triggers.await_message import
AwaitMessageTrigger
+try:
Review Comment:
Good point, but this is a real edge case that we caught in Kafka
`AwaitMessageTrigger`. So I refactor as `_CallableKwargsTrigger`, a unit test
only class that follow the Kafka `AwaitMessageTrigger` pattern instead of
directly import the provider in core tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
