uranusjr commented on code in PR #65472:
URL: https://github.com/apache/airflow/pull/65472#discussion_r3108623531
##########
providers/edge3/src/airflow/providers/edge3/models/edge_worker.py:
##########
@@ -247,6 +286,12 @@ def set_metrics(
tags={"worker_name": worker_name, "queues": ",".join(queues)},
)
+ for key in additional_keys:
+ value = sysinfo.get(key)
+ if isinstance(value, (int, float)):
Review Comment:
Same here, something should happen when the value is not a number.
(Also can the isinstance check use `numbers.Number` instead?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
