dazza-codes commented on a change in pull request #6811: [RFC][AIRFLOW-6245] Add custom waiters for AWS batch jobs URL: https://github.com/apache/airflow/pull/6811#discussion_r361009808
########## File path: tests/test_core_to_contrib.py ########## @@ -757,6 +757,11 @@ "airflow.providers.amazon.aws.operators.batch.AwsBatchOperator", "airflow.contrib.operators.awsbatch_operator.AWSBatchOperator", ), + # # Leave this out to avoid TypeError: Instance and class checks can only be used with @runtime protocols + # ( + # "airflow.providers.amazon.aws.hooks.batch_client.AwsBatchProtocol", + # "airflow.contrib.operators.awsbatch_operator.BatchProtocol", + # ), Review comment: There are some other issues with the `Protocol` implementation, e.g. - https://github.com/python/typing/issues/562 - `Protocol` might be best avoided, but that's not the point of this PR IMO, this particular protocol belongs on the `boto3` and/or `botocore` project and not here in Airflow, but since they don't provide good typing support for their dynamically generated clients, it seems to be a necessary evil (and tricky to get right and maintain). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services