Lee-W commented on code in PR #65447:
URL: https://github.com/apache/airflow/pull/65447#discussion_r3116381378
##########
task-sdk/src/airflow/sdk/execution_time/task_runner.py:
##########
@@ -1106,7 +1113,18 @@ def _serialize_outlet_events(events:
OutletEventAccessorsProtocol) -> Iterator[d
# Further filtering will be done in the API server.
for key, accessor in events._dict.items():
if isinstance(key, AssetUniqueKey):
- yield {"dest_asset_key": attrs.asdict(key), "extra":
accessor.extra}
+ event: dict[str, JsonValue] = {
+ "dest_asset_key": attrs.asdict(key),
+ "extra": accessor.extra,
+ }
+ if accessor.partition_keys:
Review Comment:
Reading this, I'm thinking whether we really should allow the partition key
to have extra 🤔 This behavior seems to be different from the override behavior
in `task-sdk/src/airflow/sdk/execution_time/context.py` which could be confusing
##########
task-sdk/src/airflow/sdk/__init__.py:
##########
@@ -202,7 +212,9 @@
"ObjectStoragePath": ".io.path",
"Param": ".definitions.param",
"ParamsDict": ".definitions.param",
+ "PartitionAtRuntime": ".definitions.timetables.simple",
Review Comment:
let's move it to assets in sdk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
