yuseok89 commented on code in PR #65418:
URL: https://github.com/apache/airflow/pull/65418#discussion_r3118406981
##########
airflow-core/src/airflow/ui/tests/e2e/pages/XComsPage.ts:
##########
@@ -125,6 +125,28 @@ export class XComsPage extends BasePage {
}
}
+ public async verifySortByColumn(columnName: string): Promise<void> {
+ await this.navigate();
+
+ const columnHeader = this.xcomsTable.locator("thead th").filter({ hasText:
columnName });
+
+ await expect(columnHeader).toBeVisible({ timeout: 10_000 });
+
+ await columnHeader.click();
+ await this.page.waitForLoadState("networkidle");
+
+ const url = this.page.url();
+
+ expect(url).toContain("sorting");
+
+ await columnHeader.click();
+ await this.page.waitForLoadState("networkidle");
+
Review Comment:
@choo121600
Thanks for the feedback.
I’m still fairly new to Playwright E2E tests, so this was a good learning
point. I've updated the test to avoid using `networkidle` by waiting for the
relevant API response and URL state instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
