dabla commented on code in PR #63614: URL: https://github.com/apache/airflow/pull/63614#discussion_r3119588735
########## providers/microsoft/azure/src/airflow/providers/microsoft/azure/triggers/synapse.py: ########## @@ -0,0 +1,165 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from __future__ import annotations + +import asyncio +import time +from collections.abc import AsyncIterator +from typing import Any + +from azure.core.exceptions import ServiceRequestError + +from airflow.providers.microsoft.azure.hooks.synapse import ( + AzureSynapsePipelineAsyncHook, + AzureSynapsePipelineRunStatus, +) +from airflow.triggers.base import BaseTrigger, TriggerEvent + + +class AzureSynapsePipelineTrigger(BaseTrigger): + """ + Trigger when an Azure Synapse pipeline run reaches a terminal state. + + If an unexpected exception occurs while polling, the trigger attempts to cancel + the pipeline run to avoid leaving orphaned executions. + + :param run_id: Pipeline run identifier. + :param azure_synapse_conn_id: Azure Synapse connection id. + :param azure_synapse_workspace_dev_endpoint: Synapse workspace dev endpoint. + :param end_time: Epoch timestamp when the trigger should timeout. + :param check_interval: Poll interval in seconds. + """ + + def __init__( + self, + run_id: str, + azure_synapse_conn_id: str, + azure_synapse_workspace_dev_endpoint: str, + end_time: float, + check_interval: int = 60, + ): + super().__init__() + + self.run_id = run_id + self.azure_synapse_conn_id = azure_synapse_conn_id + self.azure_synapse_workspace_dev_endpoint = azure_synapse_workspace_dev_endpoint + self.end_time = end_time + self.check_interval = check_interval + + def serialize(self) -> tuple[str, dict[str, Any]]: + """Serialize trigger arguments and classpath.""" + return ( + "airflow.providers.microsoft.azure.triggers.synapse.AzureSynapsePipelineTrigger", Review Comment: Same here, I would write it like this: f"{self.__class__.__module__}.{self.__class__.__name__}", ########## providers/microsoft/azure/src/airflow/providers/microsoft/azure/triggers/synapse.py: ########## @@ -0,0 +1,165 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from __future__ import annotations + +import asyncio +import time +from collections.abc import AsyncIterator +from typing import Any + +from azure.core.exceptions import ServiceRequestError + +from airflow.providers.microsoft.azure.hooks.synapse import ( + AzureSynapsePipelineAsyncHook, + AzureSynapsePipelineRunStatus, +) +from airflow.triggers.base import BaseTrigger, TriggerEvent + + +class AzureSynapsePipelineTrigger(BaseTrigger): + """ + Trigger when an Azure Synapse pipeline run reaches a terminal state. + + If an unexpected exception occurs while polling, the trigger attempts to cancel + the pipeline run to avoid leaving orphaned executions. + + :param run_id: Pipeline run identifier. + :param azure_synapse_conn_id: Azure Synapse connection id. + :param azure_synapse_workspace_dev_endpoint: Synapse workspace dev endpoint. + :param end_time: Epoch timestamp when the trigger should timeout. + :param check_interval: Poll interval in seconds. + """ + + def __init__( + self, + run_id: str, + azure_synapse_conn_id: str, + azure_synapse_workspace_dev_endpoint: str, + end_time: float, + check_interval: int = 60, + ): + super().__init__() + + self.run_id = run_id + self.azure_synapse_conn_id = azure_synapse_conn_id + self.azure_synapse_workspace_dev_endpoint = azure_synapse_workspace_dev_endpoint + self.end_time = end_time + self.check_interval = check_interval + + def serialize(self) -> tuple[str, dict[str, Any]]: + """Serialize trigger arguments and classpath.""" + return ( + "airflow.providers.microsoft.azure.triggers.synapse.AzureSynapsePipelineTrigger", Review Comment: Same here, I would write it like this: `f"{self.__class__.__module__}.{self.__class__.__name__}",` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
