haseebmalik18 opened a new pull request, #65645:
URL: https://github.com/apache/airflow/pull/65645
Improve Playwright test patterns in `XComsPage.ts` to align with best
practices.
- Replace `page.locator('[data-testid="..."]')` with `page.getByTestId()`
- Replace `locator('[role="..."]')` with `getByRole()`
- Replace CSS `filter({ hasText })` on `th` with
`getByRole("columnheader", { name })`
- Replace `locator("input")` with `getByRole("textbox")`
- Replace manual assertions (`expect(count).toBeGreaterThan(0)`) with
web-first assertions (`await expect(rows).not.toHaveCount(0)`)
- Replace `textContent()` manual checks with `not.toHaveText("")`
- Replace `page.evaluate()`-style DOM queries with locator-based `.or()`
chains
- Extract reusable `tableRows` locator to reduce repetition
closes: #63966
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
