ferruzzi commented on code in PR #65269: URL: https://github.com/apache/airflow/pull/65269#discussion_r3120895119
########## task-sdk/src/airflow/sdk/execution_time/callback_supervisor.py: ########## @@ -52,6 +72,15 @@ class _BundleInfoLike(Protocol): log: FilteringBoundLogger = structlog.get_logger(logger_name="callback_supervisor") +# The set of messages that a callback subprocess can send to the supervisor. +# This is a minimal subset of ToSupervisor: read-only access to Connections, +# Variables, and Assets, plus MaskSecret for the secrets masker. +CallbackToSupervisor = Annotated[ + GetAssetByName | GetAssetByUri | GetConnection | GetVariable | MaskSecret, Review Comment: Sorry, forgot to edit the description when I did that. I removed XCom from the PR because it follows a different pattern and will need noticeably more work than the ones included here. It's worth its own PR by the time we add the extra parameters that need to be plumbed through (dag_id, run_id, task_id) since callbacks don't have an implicit task context that those can be extracted from, the way the taskinstance does. May be a fair point on Assets. I can drop them for now and add them back if someone asks, that would leave us with just Connections, Variables, and MaskSecret as the initial set. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
