mscsy0104 opened a new pull request, #65656:
URL: https://github.com/apache/airflow/pull/65656

    <!-- SPDX-License-Identifier: Apache-2.0
         https://www.apache.org/licenses/LICENSE-2.0 -->
   Breeze used to crash with a CalledProcessError when it was not installed as 
a global uv tool or when uv was missing. This PR makes the self-upgrade check 
robust to ensure Breeze continues to function normally even if the check fails.
   
   Changed check=True to check=False in subprocess.run to prevent crashing on 
non-zero exit codes (e.g., when Breeze is installed in a venv, not as a tool).
   
   Added exception handling for FileNotFoundError to handle environments where 
uv is not installed.
   
   Added unit tests to verify that Breeze continues execution if the upgrade 
check fails.
   
   **Related Issue**
   closes: #65651
   
   ---
   
   **Tests Performed**
   We have verified the fix through both manual and automated testing.
   
   **1. Manual Verification**
   I confirmed that the crash no longer occurs when running Breeze in a uv venv 
environment without global tool installation.
   
   **2. Automated Unit Tests**
   I added new unit tests to dev/breeze/tests/test_path_utils.py to mock 
FileNotFoundError and subprocess.CalledProcessError (return code 1) to ensure 
the function returns False and Breeze does not crash.
   
   **Test Execution Results:**
   <img width="952" height="286" alt="스크린샷 2026-04-22 오후 3 17 23" 
src="https://github.com/user-attachments/assets/2a980733-6347-442e-a3a9-37e1f5e48165";
 />
   
   <!--
   Thank you for contributing!
   
   Please provide above a brief description of the changes made in this pull 
request.
   Write a good git commit message following this guide: 
http://chris.beams.io/posts/git-commit/
   
   Please make sure that your code changes are covered with tests.
   And in case of new features or big changes remember to adjust the 
documentation.
   
   Feel free to ping (in general) for the review if you do not see reaction for 
a few days
   (72 Hours is the minimum reaction time you can expect from volunteers) - we 
sometimes miss notifications.
   
   In case of an existing issue, reference it using one of the following:
   
   * closes: #ISSUE
   * related: #ISSUE
   -->
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   <!--
   If generative AI tooling has been used in the process of authoring this PR, 
please
   change below checkbox to `[X]` followed by the name of the tool, uncomment 
the "Generated-by".
   -->
   
   - [X] Yes (Gemini)
   Generated-by: Gemini following the guidelines
   
   <!--
   Generated-by: [Tool Name] following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   -->
   
   ---
   
   * Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information. Note: commit author/co-author name and email in commits 
become permanently public when merged.
   * For fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   * When adding dependency, check compliance with the [ASF 3rd Party License 
Policy](https://www.apache.org/legal/resolved.html#category-x).
   * For significant user-facing changes create newsfragment: 
`{pr_number}.significant.rst`, in 
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
 You can add this file in a follow-up commit after the PR is created so you 
know the PR number.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to