shahar1 commented on code in PR #65659: URL: https://github.com/apache/airflow/pull/65659#discussion_r3122414029
########## providers/google/src/airflow/providers/google/cloud/hooks/dataflow.py: ########## @@ -50,8 +50,16 @@ from googleapiclient.discovery import Resource, build from airflow.exceptions import AirflowProviderDeprecationWarning -from airflow.providers.apache.beam.hooks.beam import BeamHook, BeamRunnerType, beam_options_to_args -from airflow.providers.common.compat.sdk import AirflowException, timeout +from airflow.providers.common.compat.sdk import ( + AirflowException, + AirflowOptionalProviderFeatureException, + timeout, +) + +try: + from airflow.providers.apache.beam.hooks.beam import BeamHook, BeamRunnerType, beam_options_to_args +except ImportError as e: + raise AirflowOptionalProviderFeatureException(e) Review Comment: Inconsistent across providers (sometimes it's explicit, sometimes it propogates the original message). I'll make it explicit here and later we could align the rest. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
