amoghrajesh commented on code in PR #65590: URL: https://github.com/apache/airflow/pull/65590#discussion_r3122541354
########## airflow-core/src/airflow/jobs/triggerer_job_runner.py: ########## @@ -105,6 +105,12 @@ logger = logging.getLogger(__name__) tracer = trace.get_tracer(__name__) +# Private sentinel passed as the cancel message when a trigger is cancelled by user action +_USER_ACTION_CANCEL_MSG = "__airflow_user_action__" + +# Maximum seconds to wait for on_kill() before giving up. Prevents a slow or stuck +# external API call from blocking triggerer shutdown indefinitely. +_ON_CANCEL_TIMEOUT = 30 Review Comment: I just added a new configuration: `on_kill_timeout` under triggerer. Set the default to 30s by default but unsure if I should increase / reduce it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
