potiuk commented on PR #64198: URL: https://github.com/apache/airflow/pull/64198#issuecomment-4296202117
@IvanildoBarauna This PR has been converted to **draft** because it does not yet meet our [Pull Request quality criteria](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-quality-criteria). **Issues found:** - :x: **Unit tests failing across backends**: `MySQL 8.0 / Core...Serialization`, `Postgres 14 / Core...Serialization`, `Sqlite / Core...Serialization`, `LowestDeps / Core...Serialization`, plus provider-distribution compat tests against Airflow `2.11.1`, `3.0.6`, and `3.1.8`. The `...Serialization` pattern appearing on every backend suggests a regression introduced by this PR. Please reproduce with `breeze testing core-tests --test-type Core` and fix the underlying cause. - :x: **Unresolved review comments**: there are 9 unresolved review threads on this PR (5 from reviewer feedback, 4 from GitHub Copilot's automated review). Please address each one with either a code change or an in-thread reply explaining why the feedback doesn't apply, then click "Resolve conversation" once done. **What to do next:** - Fix the failing `Core...Serialization` tests — running them locally will be the fastest feedback loop. - Walk through the unresolved review threads and resolve them. - Make sure static checks pass locally: `prek run --from-ref main --stage pre-commit`. - Mark the PR as "Ready for review" when you're done. Converting a PR to draft is **not** a rejection — it is an invitation to bring the PR up to the project's standards so that maintainer review time is spent productively. There is no rush — take your time and work at your own pace. We appreciate your contribution and are happy to wait for updates. If you have questions, feel free to ask on the [Airflow Slack](https://s.apache.org/airflow-slack). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
