Copilot commented on code in PR #64879:
URL: https://github.com/apache/airflow/pull/64879#discussion_r3123936179
##########
providers/celery/tests/unit/celery/executors/test_celery_executor.py:
##########
@@ -429,14 +445,28 @@ def test_send_workloads_to_celery_hang(register_signals):
"""
executor = celery_executor.CeleryExecutor()
- workload = MockWorkload()
- workload_tuples_to_send = [(None, None, None, workload) for _ in range(26)]
+ # ``WorkloadInCelery`` is (key, workload_or_command, queue, team_name);
the 4th field must
+ # be a str | None team name, not the workload (regression after team /
ExecutorConf support).
+ if AIRFLOW_V_3_0_PLUS:
+ v3_workload = MockWorkload()
+ workload_tuples_to_send = [(None, v3_workload, None, None) for _ in
range(26)]
+ else:
+ workload_tuples_to_send = [
+ (None, _LEGACY_AIRFLOW_TASKS_RUN_CMD, None, None) for _ in
range(26)
+ ]
Review Comment:
This PR’s title/description focus on `GitDagBundle` submodule SSH env
handling, but this diff also changes Celery executor unit test
behavior/fixtures. Please either (a) justify this Celery test adjustment in the
PR description (e.g., CI fix/regression uncovered by this change) or (b) move
it to a separate PR so the Git-related change can be reviewed/merged
independently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
