dabla commented on code in PR #62790:
URL: https://github.com/apache/airflow/pull/62790#discussion_r3124707232


##########
providers/ibm/mq/src/airflow/providers/ibm/mq/hooks/mq.py:
##########
@@ -0,0 +1,404 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+from __future__ import annotations
+
+import asyncio
+import json
+import threading
+from contextlib import contextmanager, suppress
+from typing import Any
+
+from asgiref.sync import sync_to_async
+
+from airflow.providers.common.compat.sdk import BaseHook
+
+# Backoff parameters for transient consume failures
+_BACKOFF_BASE: float = 1.0
+_BACKOFF_MAX: float = 60.0
+_BACKOFF_FACTOR: float = 2.0
+
+
+class IBMMQHook(BaseHook):
+    """
+    Interact with IBM MQ queue managers to consume and produce messages.
+
+    This hook wraps the ``ibmmq`` C client and manages connection
+    lifecycle, queue open/close, and message serialization.  Both synchronous
+    (context-manager) and asynchronous (``consume`` / ``produce``) interfaces
+    are provided.
+
+    Connection parameters (host, port, login, password) are read from the
+    Airflow connection identified by *conn_id*.  ``queue_manager``, 
``channel``,
+    and ``open_options`` can be supplied either as constructor arguments or via
+    the connection's *extra* JSON — constructor arguments take precedence.
+
+    :param conn_id: Airflow connection ID for the IBM MQ instance.
+        Defaults to ``"mq_default"``.
+    :param queue_manager: Name of the IBM MQ queue manager to connect to.
+        If not provided, the value is read from the ``queue_manager`` key in
+        the connection's *extra* JSON.
+    :param channel: MQ channel name used for the connection.
+        If not provided, the value is read from the ``channel`` key in the
+        connection's *extra* JSON.
+    :param open_options: Integer bitmask of ``MQOO_*`` open options passed
+        when opening a queue (e.g.,
+        ``ibmmq.CMQC.MQOO_INPUT_SHARED | ibmmq.CMQC.MQOO_FAIL_IF_QUIESCING``).
+        If not provided, the value is resolved from the ``open_options`` key
+        in the connection's *extra* JSON, falling back to
+        ``MQOO_INPUT_SHARED``.
+    """
+
+    conn_name_attr = "conn_id"
+    default_conn_name = "mq_default"
+    conn_type = "mq"
+    hook_name = "IBM MQ"
+    default_open_options = "MQOO_INPUT_SHARED"
+
+    def __init__(
+        self,
+        conn_id: str = default_conn_name,
+        queue_manager: str | None = None,
+        channel: str | None = None,
+        open_options: int | None = None,
+    ):
+        super().__init__()
+        self.conn_id = conn_id
+        self.queue_manager = queue_manager
+        self.channel = channel
+        self.open_options = open_options
+        self._conn = None
+
+    @classmethod
+    def get_ui_field_behaviour(cls) -> dict[str, Any]:
+        """Return custom UI field behaviour for IBM MQ Connection."""
+        return {
+            "hidden_fields": ["schema"],
+            "placeholders": {
+                "host": "mq.example.com",
+                "port": "1414",
+                "login": "app_user",
+                "extra": json.dumps(
+                    {
+                        "queue_manager": "QM1",
+                        "channel": "DEV.APP.SVRCONN",
+                        "open_options": cls.default_open_options,
+                    },
+                    indent=2,
+                ),
+            },
+        }
+
+    @classmethod
+    def get_open_options_flags(cls, open_options: int) -> list[str]:
+        """
+        Return the symbolic MQ open option flags set in a given bitmask.
+
+        Each flag corresponds to a constant in ``ibmmq.CMQC`` that starts with 
``MQOO_``.
+
+        :param open_options: The integer bitmask used when opening an MQ queue
+                             (e.g., ``MQOO_INPUT_EXCLUSIVE | 
MQOO_FAIL_IF_QUIESCING``).
+
+        :return: A list of the names of the MQ open flags that are set in the 
bitmask.
+                 For example, ``['MQOO_INPUT_EXCLUSIVE', 
'MQOO_FAIL_IF_QUIESCING']``.
+
+        Example:
+            >>> open_options = ibmmq.CMQC.MQOO_INPUT_SHARED | 
ibmmq.CMQC.MQOO_FAIL_IF_QUIESCING
+            >>> cls.get_open_options_flags(open_options)
+            ['MQOO_INPUT_SHARED', 'MQOO_FAIL_IF_QUIESCING']
+        """
+        import ibmmq
+
+        return [
+            name
+            for name, value in vars(ibmmq.CMQC).items()
+            if name.startswith("MQOO_") and (open_options & value)
+        ]
+
+    @staticmethod
+    def _connect(queue_manager: str, channel: str, conn_info: str, csp):
+        """
+        Connect to the IBM MQ queue manager.
+
+        Connection errors from the C client are caught and re-raised as a
+        :class:`ConnectionError` with a human-readable message.
+
+        :return: IBM MQ connection object
+        """
+        import ibmmq
+
+        try:
+            return ibmmq.connect(queue_manager, channel, conn_info, csp=csp)
+        except (ibmmq.MQMIError, ibmmq.PYIFError) as e:
+            raise ConnectionError(
+                f"Failed to connect to IBM MQ queue manager '{queue_manager}' "
+                f"at {conn_info} on channel '{channel}': {e}"
+            ) from e
+
+    @contextmanager
+    def get_conn(self):
+        """
+        Sync context manager for IBM MQ connection lifecycle.
+
+        Must be called from the executor thread (not the event loop thread).
+        Retrieves the Airflow connection, extracts MQ parameters, and manages
+        the IBM MQ connection lifecycle.
+
+        :yield: IBM MQ connection object
+        """
+        import ibmmq
+
+        connection = BaseHook.get_connection(self.conn_id)
+        config = connection.extra_dejson
+        queue_manager = self.queue_manager or config.get("queue_manager")
+        channel = self.channel or config.get("channel")
+
+        if not queue_manager:
+            raise ValueError("queue_manager must be set in Connection extra 
config or hook init")
+        if not channel:
+            raise ValueError("channel must be set in Connection extra config 
or hook init")
+
+        if not self.open_options:

Review Comment:
   Fixed and added unit tests



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to