potiuk commented on PR #65376: URL: https://github.com/apache/airflow/pull/65376#issuecomment-4298968983
@gavrik This PR has been converted to **draft** because it does not yet meet our [Pull Request quality criteria](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-quality-criteria). **Issues found:** - :x: **Failing CI — provider backward-compat**: four checks are failing, all related to backward-compat: - `Low dep tests: providers / All-prov:LowestDeps:14:3.10:common.compat...fab` - `provider distributions tests / Compat 3.0.6:P3.10` - `provider distributions tests / Compat 3.1.8:P3.10` - `provider distributions tests / Compat 3.2.0:P3.10` The failure pattern matches what happens when a provider's public API type changes in a way that older Airflow core versions can't handle. Since the PR title is "change return type from byte to str", this is almost certainly the cause: existing callers in older core versions will break at runtime. Please either (a) keep the old type and offer `str` behind a new method / kwarg, or (b) raise the provider's `airflow>=...` lower bound to a version where the new return type is safe to assume. Reproduce locally with `breeze testing providers-tests --test-type "Providers[<provider>]"`. **What to do next:** - Fix the backward-compat issue and push. - Make sure static checks pass locally: `prek run --from-ref main --stage pre-commit`. - Mark the PR as "Ready for review" when you're done. Converting a PR to draft is **not** a rejection — it is an invitation to bring the PR up to the project's standards so that maintainer review time is spent productively. There is no rush — take your time and work at your own pace. We appreciate your contribution and are happy to wait for updates. If you have questions, feel free to ask on the [Airflow Slack](https://s.apache.org/airflow-slack). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
