potiuk commented on PR #64751:
URL: https://github.com/apache/airflow/pull/64751#issuecomment-4299430260

   @SameerMesiah97 This PR has been converted to **draft** because it does not 
yet meet our [Pull Request quality 
criteria](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-quality-criteria).
   
   **Issues found:**
   - :x: **Failing CI**: `Task SDK tests / task-sdk:P3.10 tests` is failing. 
Reproduce locally with `breeze testing task-sdk-tests` and investigate.
   - :x: **Unresolved review comments** (1 thread): please walk through each 
unresolved review thread. **Even if a suggestion looks incorrect or 
irrelevant** — and some of them will be, especially any comments left by 
automated reviewers like GitHub Copilot — it is still the author's 
responsibility to respond: apply the fix, reply in-thread with a brief 
explanation of why the suggestion does not apply, or resolve the thread if the 
feedback is no longer relevant. Leaving threads unaddressed for weeks blocks 
the PR from moving forward.
   
   **What to do next:**
   - Walk through each unresolved review thread and respond as described above.
   - Fix the Task SDK test failure and push.
   - Make sure static checks pass locally: `prek run --from-ref main --stage 
pre-commit`.
   - Mark the PR as "Ready for review" when you're done.
   
   Converting a PR to draft is **not** a rejection — it is an invitation to 
bring the PR up to the project's standards so that maintainer review time is 
spent productively. There is no rush — take your time and work at your own 
pace. We appreciate your contribution and are happy to wait for updates. If you 
have questions, feel free to ask on the [Airflow 
Slack](https://s.apache.org/airflow-slack).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to