vincbeck commented on code in PR #65692:
URL: https://github.com/apache/airflow/pull/65692#discussion_r3126593359
##########
providers/microsoft/azure/docs/secrets-backends/azure-key-vault.rst:
##########
@@ -67,6 +67,26 @@ Storing and Retrieving Variables
If you have set ``variables_prefix`` as ``airflow-variables``, then for an
Variable key of ``hello``,
you would want to store your Variable at ``airflow-variables-hello``.
+Multi-team lookup
+"""""""""""""""""
+
+In multi-team mode, this backend looks for team-scoped secrets first and falls
back to the global
+secret name when a team-scoped secret is not found.
+
+For connections:
+
+* Team-scoped: ``{connections_prefix}-{team_name}-{conn_id}``
+* Global fallback: ``{connections_prefix}-{conn_id}``
Review Comment:
We had this issue in the environment variable secret backend: what if I try
to look up the secret `marketing-secret`? It will try to look up the secret
`secret` in the team `marketing` even though I do not belong to this team? See
https://github.com/apache/airflow/blob/main/airflow-core/src/airflow/secrets/environment_variables.py#L66
I would advise:
- Adding another separator like double dash `--` between the team and
`conn_id`
- Detect the same we did in
https://github.com/apache/airflow/blob/main/airflow-core/src/airflow/secrets/environment_variables.py#L66
if a team secret is being access as a global secret
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
