gaurav0107 commented on code in PR #65685:
URL: https://github.com/apache/airflow/pull/65685#discussion_r3126682570
##########
providers/fab/docs/auth-manager/webserver-authentication.rst:
##########
@@ -42,9 +42,27 @@ following CLI commands to create an account:
--role Admin \
--email [email protected]
-To deactivate the authentication and allow users to be identified as
Anonymous, the following entry
-in ``$AIRFLOW_HOME/webserver_config.py`` needs to be set with the desired role
that the Anonymous
-user will have by default:
+To deactivate the authentication and allow users to be identified as
Anonymous, set the
+``[fab] auth_role_public`` Airflow configuration to the desired role that
anonymous users will have
Review Comment:
Good call — reverted the doc expansion entirely. The `AUTH_ROLE_PUBLIC`
paragraph is back to the upstream wording, and the new `[fab] auth_role_public`
config is documented via `provider.yaml` (which shows up in the generated
config reference). Let me know if you'd rather I add a short sentence somewhere
pointing users at the new key.
##########
providers/fab/newsfragments/65685.bugfix.rst:
##########
@@ -0,0 +1 @@
+Honor ``AUTH_ROLE_PUBLIC`` in the FastAPI-based API server. Add a new ``[fab]
auth_role_public`` Airflow configuration that is used consistently by both the
FastAPI and legacy Flask FAB auth stacks so that setting a public role actually
removes the login prompt. Setting ``AUTH_ROLE_PUBLIC`` in
``webserver_config.py`` keeps working for backwards compatibility.
Review Comment:
Removed the newsfragment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
