potiuk commented on PR #63889:
URL: https://github.com/apache/airflow/pull/63889#issuecomment-4300878079

   @Suraj-kumar00 This draft PR has not had author activity for 14 days. Before 
anyone can review it, it needs to meet our [Pull Request quality 
criteria](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-quality-criteria).
 Here is a summary of what still needs work; once those items are addressed, 
mark the PR ready for review.
   
   **Issues found:**
   - :x: **Merge conflicts**: this branch has conflicts with `main` and cannot 
be merged as-is. Rebase: `git fetch upstream main && git rebase upstream/main`, 
resolve, force-push.
   - :x: **Failing CI**: `Additional PROD image tests / Airflow CTL integration 
tests with PROD image`, `Low dep tests: providers / 
All-prov:LowestDeps:14:3.10:segment...zendesk`, `CI image checks / Static 
checks`. Please investigate and fix.
   - :x: **Unresolved review comments** (14 threads (from maintainers)): please 
walk through each unresolved review thread. **Even if a suggestion looks 
incorrect or irrelevant** — and some of them will be, especially any comments 
left by automated reviewers like GitHub Copilot — it is still the author's 
responsibility to respond: apply the fix, reply in-thread with a brief 
explanation of why the suggestion does not apply, or resolve the thread if the 
feedback is no longer relevant. **Once you believe a thread is resolved — 
whether by pushing a fix or by explaining why the suggestion doesn't apply — 
please mark it as resolved yourself by clicking the 'Resolve conversation' 
button at the bottom of each thread.** Reviewers don't auto-close their own 
threads, so an addressed-but-unresolved thread reads as 'still waiting on the 
author' and keeps the PR from moving forward.
   
   **What to do next:**
   - Address the items above.
   - Make sure static checks pass locally: `prek run --from-ref main --stage 
pre-commit`.
   - Mark the PR as "Ready for review" when you are done.
   
   There is no rush — take your time and work at your own pace. We appreciate 
your contribution and are happy to wait for updates. If you have questions, 
feel free to ask on the [Airflow Slack](https://s.apache.org/airflow-slack).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to