sunildataengineer commented on PR #65480:
URL: https://github.com/apache/airflow/pull/65480#issuecomment-4301139573
@srchilukoori All review feedback has been addressed:
1. Extracted SFTPOperation into constants.py — circular import fixed
2. Added full type annotations to SFTPOperatorTrigger.__init__(),
serialize(), run(), _do_transfer()
3. Added remote_host, concurrency, prefetch to trigger __init__
and serialize()
4. Fixed directory transfer support in _do_transfer() — handles
isdir() check and calls retrieve_directory/store_directory correctly
5. Replaced asyncio.get_event_loop() with asyncio.get_running_loop()
6. Removed inner imports from test methods
7. Added SFTPOperatorTrigger tests: serialize() roundtrip,
run() success path, run() error path
All 6 tests passing locally. Ready for re-review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
