wjddn279 opened a new pull request, #65705: URL: https://github.com/apache/airflow/pull/65705
Closes: https://github.com/apache/airflow/issues/65674 In `serailized_dag`, `op_args` of task_id `transform.to_exp` is changed in every parsing, because `DagParam` has no stringfy function ``` "op_args": "(MappedArgument(_input=DictOfListsExpandInput(value={'number': XComArg(<Task(_PythonDecoratedOperator): get_data>)}), _key='number'), <airflow.sdk.definitions.param.DagParam object at 0xf96d2cd44a60>)", ``` The `template_field` ends up as a tuple, but since it contains an object type, `is_jsonable` returns False. Because tuple has no serialize path, execution falls into [this logic](https://github.com/wjddn279/airflow/blob/main/airflow-core/src/airflow/serialization/helpers.py#L84), and the plain string conversion embeds the raw object representation (including its id), which is highly likely to cause Dag inflation. I means the logic needs to be modified to handle the case not `is_jsonable` but list, tuple, dict type like this https://github.com/apache/airflow/pull/63871 <!-- SPDX-License-Identifier: Apache-2.0 https://www.apache.org/licenses/LICENSE-2.0 --> <!-- Thank you for contributing! Please provide above a brief description of the changes made in this pull request. Write a good git commit message following this guide: http://chris.beams.io/posts/git-commit/ Please make sure that your code changes are covered with tests. And in case of new features or big changes remember to adjust the documentation. Feel free to ping (in general) for the review if you do not see reaction for a few days (72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications. In case of an existing issue, reference it using one of the following: * closes: #ISSUE * related: #ISSUE --> --- ##### Was generative AI tooling used to co-author this PR? <!-- If generative AI tooling has been used in the process of authoring this PR, please change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by". --> - [ ] Yes (please specify the tool below) <!-- Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions) --> --- * Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged. * For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. * When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). * For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
