snowlaxc opened a new pull request, #65710:
URL: https://github.com/apache/airflow/pull/65710
Fix '/auth/token' 500 when FAB auth manager is recreated
'init_auth_manager()' initializes the global auth manager and
'FabAuthManager.get_fastapi_app()' stores the Flask app used by the
FAB-backed auth routes on that instance.
Later, 'init_appbuilder()' calls 'create_auth_manager()' again. That
replaces the initialized global auth manager with a fresh instance that
does not have 'flask_app' set, causing '/auth/token' to fail with:
'Flask app is not initialized. Check that FabAuthManager started up
correctly.'
This change reuses the already initialized auth manager when available
and only falls back to 'create_auth_manager()' if initialization has
not happened yet.
This was reproduced on Airflow 3.1.2 deployments using
'FabAuthManager', where:
- 'POST /auth/token' returned '500' before the patch
- empty request bodies return '400' after the patch
- valid username/password requests return '201' and a JWT after the patch
## Validation
Manually reproduced before the patch:
- 'POST /auth/token' returned '500'
Manually validated after the patch:
- empty request body returns '400'
- valid username/password returns '201'
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
- [ ] Yes (please specify the tool below)
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
'{pr_number}.significant.rst', in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
