yuseok89 opened a new pull request, #65724:
URL: https://github.com/apache/airflow/pull/65724
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
`S3ToGCSOperator` now drops S3 keys that end with `/`.
## Problem
1. Listing objects for a given bucket and prefix (e.g. folder_name/) can
return trailing-`/` keys. Previously they were included in execute's return
value and XCom (`gs://…/folder_name/`).
2. With deferrable=True, that list is sent to Storage Transfer as
includePrefixes. A key like `folder_name/` is a strict prefix of keys such as
`folder_name/file.txt`, which the API rejects with HTTP 400 (overlapping
include prefixes).
## Solution
- Omit keys ending with `/` from the list used for transfer and for execute.
- This matches typical S3 folder placeholders; ordinary data object keys
rarely end with `/`.
## Screenshots
### Before
Trailing `/` in XCom
<img width="1024" height="302" alt="image"
src="https://github.com/user-attachments/assets/5187be7c-fd27-4a8a-b8c3-283ac83b4ea2";
/>
Deferrable / Storage Transfer includePrefixes error
<img width="1038" height="332" alt="image"
src="https://github.com/user-attachments/assets/70041802-167f-42a9-86f4-660e45a7fd3f";
/>
### After
No trailing `/` in XCom
<img width="1169" height="344" alt="image"
src="https://github.com/user-attachments/assets/b9d3252d-6958-46a3-a53b-90db75a0894b";
/>
Deferrable run succeeds
<img width="1174" height="242" alt="image"
src="https://github.com/user-attachments/assets/ccd83fad-2bd8-459a-b03b-287ba3e41893";
/>
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [x] Yes (please specify the tool below)
- Cursor
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
