srchilukoori opened a new pull request, #65731:
URL: https://github.com/apache/airflow/pull/65731
## Description
`GenAIGenerativeModelHook.get_genai_client()` constructs a `genai.Client`
without passing credentials, causing it to fall back to Application Default
Credentials (ADC) even when `gcp_conn_id` is set to an explicit service-account
connection. Users in environments without ADC (e.g. Docker containers,
on-premise) receive `DefaultCredentialsError` at runtime.
The fix passes `self.get_credentials()` to `genai.Client`, which is the same
pattern used by every other Google provider hook (GCS, BigQuery, Vertex AI,
etc.).
Fixes #65709
## Changes
- `providers/google/src/airflow/providers/google/cloud/hooks/gen_ai.py`:
Pass `credentials=self.get_credentials()` to `genai.Client` in
`GenAIGenerativeModelHook.get_genai_client()`.
- `providers/google/tests/unit/google/cloud/hooks/test_gen_ai.py`: Add
`test_get_genai_client_passes_connection_credentials` to assert credentials
from the connection are forwarded to the client.
## Root Cause
```python
# Before — credentials omitted, ADC used regardless of gcp_conn_id
def get_genai_client(self, project_id: str, location: str):
return genai.Client(
vertexai=True,
project=project_id,
location=location,
)
# After — honours the configured Airflow connection
def get_genai_client(self, project_id: str, location: str):
return genai.Client(
vertexai=True,
project=project_id,
location=location,
credentials=self.get_credentials(),
)
```
---
##### Was generative AI tooling used to co-author this PR?
- [x] Yes Claude
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
