amoghrajesh opened a new issue, #65733:
URL: https://github.com/apache/airflow/issues/65733

   ### Body
   
   ### What / Why?
   
   `BaseTrigger` now has an `on_kill()` hook ( added via: 
https://github.com/apache/airflow/pull/65590) that fires only on user-initiated 
task kills. 
   
   Three triggers already implement cancellation but using the old pattern — 
catching `asyncio.CancelledError` in `run()` with a `safe_to_cancel()` check. 
These should be migrated.
   
   ### Tasks
   
   - [ ] DataprocSubmitTrigger
   - [ ] DataprocSubmitJobDirectTrigger
   - [ ] EmrServerlessStartJobTrigger 
   - [ ] KubernetesPodTrigger
   
   ### What to do:
   
   Move the cancellation call out of the CancelledError handler in run(), drop 
the safe_to_cancel() check, implement on_kill() instead. See the Databricks PR 
for a reference implementation.
   
   
   Drop a comment claiming which trigger you will be working on — first to 
comment gets precedence to avoid duplicate work.
   
   ### Committer
   
   - [x] I acknowledge that I am a maintainer/committer of the Apache Airflow 
project.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to