david-parkk opened a new pull request, #65734: URL: https://github.com/apache/airflow/pull/65734
## Summary Add `()` to `KafkaError.name()` call in `create_topic` so that `TOPIC_ALREADY_EXISTS` is correctly handled as a warning instead of being re-raised as an error. ## Analysis Checked the original Kafka provider code addition in https://github.com/apache/airflow/pull/30175. In the current `KafkaAdminClientHook.create_topic()`, `TOPIC_ALREADY_EXISTS` is intentionally treated as a warning rather than an error — understood as an idempotency design decision where an already-existing topic is considered a valid state. However, `KafkaError.name` is a method, not a property. Without `()`, the comparison is made against a bound method object (always truthy), so the condition never matches and `TOPIC_ALREADY_EXISTS` is always re-raised as an exception. Confirmed by observing DAG failures on `TOPIC_ALREADY_EXISTS` with confluent-kafka 2.14.0 and Kafka broker 4.2.0 (`apache/kafka` Docker image) on Breeze dev environment. <img width="1415" height="617" alt="image" src="https://github.com/user-attachments/assets/ff6ee033-477d-471a-b806-ce04d84a6d29"; /> ## Changes Added `()` to `e.args[0].name()` to perform the correct string comparison against `"TOPIC_ALREADY_EXISTS"`. ## Test - Renamed test to `test_create_topic_already_exists_no_exception_but_warning` to better describe the expected behaviour - Replaced `caplog` with `patch.object(hook.log, "warning")` as recommended in the project's testing guidelines - All provider tests pass (`breeze testing providers-tests --test-type "Providers[apache.kafka]"`) - Static checks pass (`prek run --all-files`) --- I'm happy to make any adjustments based on your feedback. Thank you to the maintainers for taking the time to review this contribution! <!-- SPDX-License-Identifier: Apache-2.0 https://www.apache.org/licenses/LICENSE-2.0 --> <!-- Thank you for contributing! Please provide above a brief description of the changes made in this pull request. Write a good git commit message following this guide: http://chris.beams.io/posts/git-commit/ Please make sure that your code changes are covered with tests. And in case of new features or big changes remember to adjust the documentation. Feel free to ping (in general) for the review if you do not see reaction for a few days (72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications. In case of an existing issue, reference it using one of the following: * closes: #ISSUE * related: #ISSUE --> --- ##### Was generative AI tooling used to co-author this PR? <!-- If generative AI tooling has been used in the process of authoring this PR, please change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by". --> - [x] Yes (please specify the tool below) Generated-by: Claude following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions) <!-- Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions) --> --- * Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged. * For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. * When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). * For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
