riyanmohmmeed-dev opened a new pull request, #65740:
URL: https://github.com/apache/airflow/pull/65740
Migrate `EmrServerlessStartJobTrigger` from the old `asyncio.CancelledError`
catch pattern to the new `BaseTrigger.on_kill()` hook (added via #65590).
**Changes:**
- Add `async on_kill()` method that cancels the EMR Serverless job only on
user-initiated task kills
- Remove the `CancelledError` handler from `run()`, letting the parent class
`AwsBaseWaiterTrigger.run()` handle the standard waiter flow
- Remove `safe_to_cancel()`, `get_task_instance()`, `get_task_state()` which
are no longer needed (`on_kill` only fires on user kills)
- Clean up unused imports (`asyncio`, `AIRFLOW_V_3_0_PLUS`,
`TaskInstanceState`, etc.)
- Update tests to directly verify `on_kill()` behavior
Follows the same pattern as the Databricks trigger migration in #65590.
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #65733
-->
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes — Gemini
Generated-by: Gemini following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
