MdSadiqMd opened a new pull request, #65751:
URL: https://github.com/apache/airflow/pull/65751
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
Branch operators inside TaskGroups now correctly skip non-selected sibling
tasks when returning relative task IDs. Previously, a branch callable inside
group "g" that returned "path_a" would fail to skip sibling task "path_b"
because the branching logic only recognized fully-qualified IDs like "g.path_a".
This fix allows branch callables to return either:
- Relative IDs: `"path_a"` (more intuitive)
- Absolute IDs: `"g.path_a"` (backward compatible)
Both formats now work correctly, preventing unnecessary task execution and
resource waste in production environments (particularly KubernetesExecutor
where each task starts a pod).
**Changes:**
- Added `_resolve_branch_id()` method to resolve relative task IDs within
TaskGroups
- Applied fix to both `task-sdk` and `providers/standard` distributions
- Added regression tests covering both relative and absolute ID formats
- Added unit tests for the resolution logic
**Testing:**
- New parametrized integration test: `test_branch_inside_task_group`
- New unit test:
`test_expand_task_group_roots_resolves_relative_id_inside_group`
- All existing branch operator tests pass
closes: #65745
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [x] Yes — Claude Code
Generated-by: Claude Code following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
