Subham-KRLX commented on PR #65744: URL: https://github.com/apache/airflow/pull/65744#issuecomment-4313836950
Thanks for working on this migration there’s a duplicate cancel_on_kill=False in the test file causing a failure so please remove it for backward compatibility keep the CancelledError handler minimal and re raise it since it should generally propagate also remove the now unused methods (safe_to_cancel(), get_task_instance(), get_task_state()) and make sure the on_kill() implementation is included. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
