sokratis1988 opened a new pull request, #65791:
URL: https://github.com/apache/airflow/pull/65791
Currently, git-sync environment variables (GIT_SYNC_REPO, GIT_SYNC_REV,
GIT_SYNC_BRANCH, GITSYNC_REF, etc.) are hardcoded in the `git_sync_container`
helper template and read from values.yaml. If a user tries to override them via
`dags.gitSync.env`, the container ends up with duplicate entries for the same
variable name.
This PR:
- Adds a `git_sync_env_not_overridden` helper that skips the hardcoded
default when the same variable is provided in `dags.gitSync.env`,
preventing duplicates.
- Introduces `dags.gitSync.envVarsSecret` to load configurable git-sync
variables from a Kubernetes Secret via `secretKeyRef` (with
`optional: true`), following the same pattern as `credentialsSecret`
for `GIT_SYNC_USERNAME` / `GIT_SYNC_PASSWORD`.
- Extends the JSON schema in `values.schema.json` accordingly.
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
