dabla commented on PR #65792: URL: https://github.com/apache/airflow/pull/65792#issuecomment-4315539214
> Sounds reasonable for me - with current code ALL triggeres pick up the task in parallel? As I am not an expert would need another pair of eyes for review. > > Would request an expert review from @uranusjr or @dabla maybe if not @ashb. I think @ashb or @uranusjr are the biggest experts on that field. Looks good to me but a proof of logging that it works would maybe be an option. Also dunno how SQLAlchemy queries are being unit tested at all. Would be good if we would have a unit test that guards this specific code from regression if future changes would occur. WDYT @jscheffl ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
