amoghrajesh commented on code in PR #65759: URL: https://github.com/apache/airflow/pull/65759#discussion_r3141521870
########## shared/state/src/airflow_shared/state/__init__.py: ########## @@ -0,0 +1,79 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +from abc import ABC, abstractmethod +from dataclasses import dataclass + + +@dataclass(frozen=True) +class TaskScope: + """Identifies the state namespace for a single task instance (or retry thereof).""" + + dag_id: str + run_id: str + task_id: str + map_index: int = -1 + + +@dataclass(frozen=True) +class AssetScope: + """Identifies the state namespace for an asset.""" + + asset_id: str + + +StateScope = TaskScope | AssetScope + + +class BaseStateBackend(ABC): + """ + Abstract backend for reading and writing task and asset state. + + - Sync methods are abstract. + - Async methods default to calling their sync counterparts so that sync-only backends (e.g. the default metastore backend) + get async support for free. Backends with native async I/O (e.g. S3) should + override the async methods. + """ + + @abstractmethod + def get(self, scope: StateScope, key: str) -> str | None: + """Return the stored value, or None if the key does not exist.""" + + @abstractmethod + def set(self, scope: StateScope, key: str, value: str) -> None: + """Write or overwrite the value for the given key.""" + + @abstractmethod + def delete(self, scope: StateScope, key: str) -> None: + """Delete a single key. No-op if the key does not exist.""" + + @abstractmethod + def clear(self, scope: StateScope) -> None: + """Delete all keys under the given scope.""" + + async def aget(self, scope: StateScope, key: str) -> str | None: + return self.get(scope, key) + + async def aset(self, scope: StateScope, key: str, value: str) -> None: + self.set(scope, key, value) + + async def adelete(self, scope: StateScope, key: str) -> None: + self.delete(scope, key) + + async def aclear(self, scope: StateScope) -> None: + self.clear(scope) Review Comment: ACK, made the change for that and updated PR desc too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
