Pranaykarvi commented on issue #65827: URL: https://github.com/apache/airflow/issues/65827#issuecomment-4318529065
Looking into this as a follow-up once #65570 lands. One thing worth flagging in the proposed design: the issue states that `get_handler`'s `TypeError` is "caught by the existing exception handling in `handle_requests`" — but the current `handle_requests` only catches `ServerResponseError`. An unregistered message type would propagate out of the generator and crash the request loop entirely rather than sending an error response back to the subprocess. I've got a local branch (`refactor/handler-registry-65827`) with the registry primitives (`_HANDLER_REGISTRY`, `handles()`, `get_handler()`) in a new `request_handlers.py`, the base class dispatch wired in `WatchedSubprocess._handle_request`, and the `TypeError` handling added alongside the existing `ServerResponseError` catch. Holding off on the PR until #65570 merges since the handler decorations and subclass cleanup depend on those shared functions existing first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
