ericxiao251 commented on code in PR #65852:
URL: https://github.com/apache/airflow/pull/65852#discussion_r3143903952
##########
chart/templates/workers/worker-deployment.yaml:
##########
@@ -348,7 +348,7 @@ spec:
{{- if and .Values.dags.gitSync.enabled (not
.Values.dags.persistence.enabled) }}
{{- include "git_sync_container" . | nindent 8 }}
{{- end }}
- {{- if and $persistence .Values.workers.logGroomerSidecar.enabled }}
+ {{- if .Values.workers.logGroomerSidecar.enabled }}
Review Comment:
> I think comparing both solutions I think adding another parameter just to
100% keep backcompat is a bit too much.
Ya I agree with all your points, why I decided to go with the non backward
compatible method.
With a backward compatible change - would we ensure pods are not recreated
and be less disruptive? That would be the only significant benefit I can see.
---
Sidenote - I was a bit shocked to find out the log groomer only worked with
persistence enabled, does that mean that's typically what people are setting on
the worker deployment? Or perhaps just manually adding the log groomer
container to the values.
Trying to understand what the norm is and if we're just the odd one out with
not using persistence.
##########
chart/templates/workers/worker-deployment.yaml:
##########
@@ -348,7 +348,7 @@ spec:
{{- if and .Values.dags.gitSync.enabled (not
.Values.dags.persistence.enabled) }}
{{- include "git_sync_container" . | nindent 8 }}
{{- end }}
- {{- if and $persistence .Values.workers.logGroomerSidecar.enabled }}
+ {{- if .Values.workers.logGroomerSidecar.enabled }}
Review Comment:
> I think comparing both solutions I think adding another parameter just to
100% keep backcompat is a bit too much.
Ya I agree with all your points, why I decided to go with the non backward
compatible method.
With a backward compatible change - would we ensure pods are not recreated
and be less disruptive? That would be the only significant benefit I can see.
---
Sidenote - I was a bit shocked to find out the log groomer only worked with
persistence enabled, does that mean that's typically what people are setting on
the worker deployment? Or perhaps just manually adding the log groomer
container to the values.
Trying to understand what the norm is and if we're just the odd one out with
not using persistence.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
