potiuk opened a new pull request, #65918:
URL: https://github.com/apache/airflow/pull/65918
Updates the `pr-triage` skill so workflow-approval PRs are presented
as a list with full details printed up front, then a single selection
screen where the maintainer picks which subset to approve, flag, or
skip — instead of the previous one-at-a-time inspect-and-confirm
loop.
## What changed
`.github/skills/pr-triage/workflow-approval.md`:
- Phase 1 prints every PR's inspection block (title, author signals,
changed files, suspicious-pattern matches, CI-adjacent diff
excerpts) back-to-back. No prompts in between — the maintainer
scrolls through them.
- Phase 2 is a single selection screen with three input lines:
*Approve indices*, *Flag-suspicious indices*, *Skip indices* (the
last is implicit for any unlisted index). Comma-separated indices,
ranges (`1-3`), or the literal `default` token (Approve only).
- Defaults are encoded per row (`← default APPROVE` / `← default
SKIP`) — they're guidance, not auto-fill. The maintainer always
has to type indices to act, and there is no "approve all"
shortcut. Any suspicious-pattern match or CI-adjacent file change
flips the default to SKIP.
- Confirmation step: print resolved verbs + affected authors, ask
`proceed? [y/N]`. Anything other than `y` re-shows the selection
screen with the indices pre-filled so the maintainer can edit.
- Execution order is fixed: approve → flag → skip; one per-PR
failure in the batch surfaces the error and continues with the
rest (matching the shape of a Ctrl-C'd per-PR session).
`.github/skills/pr-triage/interaction-loop.md`:
- The `(pending_workflow_approval, *)` group entry now points to
the dedicated list-then-select flow and explicitly bypasses the
generic `[A]/[E]/[P]/[O]/[S]/[Q]` group menu.
- The "destructive groups need per-PR confirm" paragraph drops
`pending_workflow_approval` from the list (it has its own
selection-and-confirm step) but keeps the rule for
`(deterministic_flag, close)` and `(stale_draft, close)`.
## Why
The per-PR confirm-and-approve loop was too slow when several
first-time-contributor PRs landed at once — the maintainer ended up
scrolling and pressing `A` over and over for trivially-clean PRs.
The list-then-select pattern keeps the safety property (every
approval still requires the maintainer to type the index, and
suspicious PRs default to SKIP) while collapsing N keystrokes into
one input.
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes — Claude Code (Opus 4.7)
Generated-by: Claude Code (Opus 4.7) following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
