bbovenzi commented on code in PR #65730:
URL: https://github.com/apache/airflow/pull/65730#discussion_r3147998002
##########
airflow-core/src/airflow/ui/tests/e2e/pages/XComsPage.ts:
##########
@@ -114,9 +116,11 @@ export class XComsPage extends BasePage {
await expect(firstKeyCell).toContainText(keyPattern, { ignoreCase: true
});
}).toPass({ timeout: 30_000 });
- await expect(this.tableRows).not.toHaveCount(0);
+ const rows = this.xcomsTable.locator("tbody tr");
+
+ await expect(rows).not.toHaveCount(0);
- const rowCount = await this.tableRows.count();
+ const rowCount = await rows.count();
for (let i = 0; i < Math.min(rowCount, 3); i++) {
const keyCell = this.tableRows.nth(i).locator("td").first();
Review Comment:
Same this.tableRows -> rows here too
##########
airflow-core/src/airflow/ui/tests/e2e/pages/XComsPage.ts:
##########
@@ -82,9 +82,11 @@ export class XComsPage extends BasePage {
await expect(firstLink).toContainText(dagDisplayNamePattern, {
ignoreCase: true });
}).toPass({ timeout: 30_000 });
- await expect(this.tableRows).not.toHaveCount(0);
+ const rows = this.xcomsTable.locator("tbody tr");
- const rowCount = await this.tableRows.count();
+ await expect(rows).not.toHaveCount(0);
+
+ const rowCount = await rows.count();
for (let i = 0; i < Math.min(rowCount, 3); i++) {
const dagIdLink =
this.tableRows.nth(i).locator("a[href*='/dags/']").first();
Review Comment:
Let's switch `this.tableRows` to use the new rows var
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
