amoghrajesh opened a new pull request, #66002:
URL: https://github.com/apache/airflow/pull/66002
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [x] Yes : claude sonnet 4.5
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
After https://github.com/apache/airflow/pull/55068 was merged,
inconsequentially, `_decode_start_trigger_args` was deserializing
`trigger_kwargs` and `next_kwargs` when loading a serialized DAG. These fields
hold the serialized trigger state that only the Triggerer needs — when it picks
up a deferred task, inflates the kwargs, and instantiates the trigger class.
The Scheduler and API Server load serialized DAGs but never touch these
values; deserializing them there is wasted work.
This PR removes the deserialization and keeps `trigger_kwargs` and
`next_kwargs` as raw JSON on `StartTriggerArgs`. The Triggerer reads trigger
kwargs directly from the Trigger DB row (not through DAG deserialization), so
its path is unaffected: `airflow-core/src/airflow/models/trigger.py#L170-L179`
### What changes?
#### Scheduler
##### Before:
```
DagSerialization.from_dict()
→ _decode_start_trigger_args()
→ BaseSerialization.deserialize(trigger_kwargs) # inflate to Python
objects
→ StartTriggerArgs.trigger_kwargs = {delta: timedelta(...)}
```
```
TI.schedule_tis()
→ Trigger(kwargs=trigger_kwargs)
→ encrypt_kwargs() → serde.serialize() → json → fernet → encrypted_kwargs
(DB)
```
After:
```
DagSerialization.from_dict()
→ _decode_start_trigger_args()
→ StartTriggerArgs.trigger_kwargs = {"__type": "dict", "__var": {...}} #
raw JSON, no work done
```
```
TI.schedule_tis()
→ Trigger(kwargs=trigger_kwargs)
→ encrypt_kwargs() → serde.serialize() → json → fernet → encrypted_kwargs
(DB)
```
The `Trigger.__init__` calls `serde.serialize()` on whatever it receives, so
deserializing then re-serializing was pure waste.
#### API Server
Before: loads serialized DAG → `_decode_start_trigger_args()` which
deserializes `trigger_kwargs` into Python objects → never used, thrown away.
After: same but stays raw JSON. No functional difference, just skips the
work.
#### Triggerer
Before and after:
The triggerer also loads the serialized DAG at
https://github.com/apache/airflow/blob/main/airflow-core/src/airflow/jobs/triggerer_job_runner.py#L717-L735
to check start_from_trigger. So it does go through
`_decode_start_trigger_args()` too, but it does not use trigger_kwargs from
that — it reads `trigger.encrypted_kwargs` from the DB row directly below. So
the fix is safe for the triggerer as well.
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
