uranusjr commented on code in PR #65197:
URL: https://github.com/apache/airflow/pull/65197#discussion_r3152982851
##########
providers/google/tests/system/google/cloud/cloud_sql/example_cloud_sql_query_iam.py:
##########
@@ -386,13 +386,12 @@ def save_ssl_cert_locally(ssl_cert: dict[str, Any],
db_type: str) -> dict[str, s
)
task_id = f"example_cloud_sql_query_ssl_{database_type}"
- ssl_server_cert_path = (
- f"{{{{
task_instance.xcom_pull('save_ssl_cert_locally_{database_type}')['sslrootcert']
}}}}"
- )
- ssl_cert_path = (
- f"{{{{
task_instance.xcom_pull('save_ssl_cert_locally_{database_type}')['sslcert']
}}}}"
- )
- ssl_key_path = f"{{{{
task_instance.xcom_pull('save_ssl_cert_locally_{database_type}')['sslkey'] }}}}"
+ # verbose form: "{{
task_instance.xcom_pull('save_ssl_cert_locally_{database_type}')['sslrootcert']
}}"
+ ssl_server_cert_path = f"{{{{
save_ssl_cert_locally_{database_type}.output['sslrootcert'] }}}}"
+ # verbose form: "{{
task_instance.xcom_pull('save_ssl_cert_locally_{database_type}')['sslcert'] }}"
+ ssl_cert_path = f"{{{{
save_ssl_cert_locally_{database_type}.output['sslcert'] }}}}"
+ # verbose form: "{{
task_instance.xcom_pull('save_ssl_cert_locally_{database_type}')['sslkey'] }}"
+ ssl_key_path = f"{{{{
save_ssl_cert_locally_{database_type}.output['sslkey'] }}}}"
Review Comment:
Same, I don’t think these work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
