amoghrajesh commented on code in PR #65759: URL: https://github.com/apache/airflow/pull/65759#discussion_r3153682161
########## shared/state/src/airflow_shared/state/__init__.py: ########## @@ -0,0 +1,76 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +from abc import ABC, abstractmethod +from dataclasses import dataclass + + +@dataclass(frozen=True) +class TaskScope: + """Identifies the state namespace for a single task instance (or retry thereof).""" + + dag_id: str + run_id: str + task_id: str + map_index: int = -1 + + +@dataclass(frozen=True) +class AssetScope: + """Identifies the state namespace for an asset.""" + + asset_id: int + + +StateScope = TaskScope | AssetScope + + +class BaseStateBackend(ABC): Review Comment: Thanks. I went with documentation over splitting. Splitting into `TaskStateBackend` + `AssetStateBackend` would double the config surface ([state] task_backend + [state] asset_backend), require two separate instances everywhere the backend is used, and make the StateScope union type redundant imo. Updated `BaseStateBackend` with a class-level docstring showing the standard dispatch pattern, and added "Must handle both TaskScope and AssetScope" not in each abstract method. Custom backend authors should have everything they need from the interface doc alone. OR we can have abstract methods like: `get_task_state`, `get_asset_state`, the cost of which will be that abstract method count doubles. Any preference? I am ok with both -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
