anishgirianish commented on code in PR #62343:
URL: https://github.com/apache/airflow/pull/62343#discussion_r3157912925
##########
airflow-core/src/airflow/models/crypto.py:
##########
@@ -93,6 +96,66 @@ def rotate(self, msg: bytes | str) -> bytes:
return self._fernet.rotate(msg)
+class FernetFieldsMixin:
+ """
+ Mixin providing Fernet-encrypted ``password`` and ``extra`` fields.
+
+ Subclasses get ``_password`` / ``_extra`` mapped columns and transparent
+ encrypt-on-write / decrypt-on-read via SQLAlchemy synonyms.
+
+ Models that need additional logic (e.g. the ``Connection`` model's
+ ``is_encrypted`` flag) can override ``get_password``, ``set_password``,
+ ``get_extra``, and ``set_extra``.
Review Comment:
Done, FernetFieldsMixin now owns is_encrypted/is_extra_encrypted and raises
ValueError("…FERNET_KEY configuration is missing"). Connection drops its
duplicates; ConnectionTestRequest inherits.
thank you
##########
airflow-core/src/airflow/executors/workloads/connection_test.py:
##########
@@ -0,0 +1,88 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""Connection test workload schema for executor communication."""
+
+from __future__ import annotations
+
+import uuid
+from typing import TYPE_CHECKING, Literal
+
+from pydantic import Field
+
+from airflow.executors.workloads.base import BaseWorkloadSchema
+from airflow.models.connection_test import ConnectionTestKey
+
+if TYPE_CHECKING:
+ from airflow.api_fastapi.auth.tokens import JWTGenerator
+ from airflow.models.connection_test import ConnectionTestState
+
+
+class TestConnection(BaseWorkloadSchema):
+ """Execute a connection test on a worker."""
+
+ connection_test_id: uuid.UUID
+ connection_id: str
+ timeout: int = 60
Review Comment:
Removed thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
