jason810496 commented on code in PR #65956: URL: https://github.com/apache/airflow/pull/65956#discussion_r3158818247
########## java-sdk/validation/serialization/compare.py: ########## @@ -0,0 +1,171 @@ +#!/usr/bin/env python3 +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +""" +Compare serialised DAG output from Python and Java SDKs. + +Usage: + python compare.py serialized_python.json serialized_java.json +""" + +from __future__ import annotations + +import json +import sys +from pathlib import Path + +# Fields that are inherently environment-specific and should be ignored. +IGNORED_FIELDS = frozenset( + { + "fileloc", + "relative_fileloc", + "_processor_dags_folder", + } +) + +# Floating-point tolerance for timestamp / duration comparisons. +FLOAT_TOLERANCE = 1e-6 Review Comment: I will go through the comparison throughly later, I will blame to claude code for now :D . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
