jason810496 commented on code in PR #65958: URL: https://github.com/apache/airflow/pull/65958#discussion_r3158953826
########## shared/workloads/src/airflow_shared/workloads/__init__.py: ########## Review Comment: If we take a look at the TODO of TaskSDK entrypoint for base executor here: https://github.com/apache/airflow/pull/65958/changes#diff-1e0f743cefff2cac05b7e42916d0d111351533da07fa0439bb6cfba1d05cfaf6R651-R653 Having shared distribution for `TaskInstanceDTO` is one of the correct and accurate way to solve the TODO and expose the `ti.queue` attribute to TaskSDK (we need the `queue` from operator to match the correct coordinator in task-runner now). We're really using `TaskInstanceDTO` in TaskSDK, but we just cast it as `airflow.sdk.api.datamodels._generated.TaskInstance` since AF 3.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
